[D7] MaPS Cleaner

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxFonski2446651git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Git clone failed. Please update the correct git clone url.

Hi Fonski,
I am not able to test module with installation and enabling. I donot have details for dependency module "MaPS Suite". If you could make it available for me, Will continue with further module review.

Please have a look into following issue regarding code.

Automated testing:
Link http://pareview.sh/pareview/httpgitdrupalorgsandboxfonski2446651git

Manual testing:

severity: criticalreview: security_3
Line 188: Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs) [security_3]

        drupal_set_message(t("Force reimport successful for entity !uid", array('!uid' => $uid)));

severity: criticalreview: security_3
Line 191: Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs) [security_3]

        drupal_set_message(t("Force reimport failed for object !uid", array('!uid' => $uid)), 'error');

Hi,

No need to set required version of php in .info file, Drupal has already. Refer this https://www.drupal.org/requirements.

name = MaPS Cleaner
description = Cleaner module for MaPS Suite.
package = MaPS Suite
core = 7.x
php = 5.3

Hi Fonski

Automatic review
Need to fix the errors
167 | WARNING | The extra check_plain() is not necessary for
| | placeholders, "@" and "%" will automatically run
| | check_plain()
170 | WARNING | The extra check_plain() is not necessary for
| | placeholders, "@" and "%" will automatically run
| | check_plain()
188 | WARNING | The extra check_plain() is not necessary for
| | placeholders, "@" and "%" will automatically run
| | check_plain()
191 | WARNING | The extra check_plain() is not necessary for
| | placeholders, "@" and "%" will automatically run
| | check_plain()

Manual Review
In .info file no need to add php version(php = 5.3)

Individual user account
Yes: Follows follow the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
Yes: Follows the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements. / No: List of security issues identified.]
Coding style & Drupal API usage
[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:

Config Link is not available in .info file

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.