| Rajab Natshah |
Yes it was like a party for the Acquia's Drupal Acceleration TeamTim Plunkett (tim.plunkett) told meI'd recommend waiting on this until after out hackathon this week. Lots of code changes in MRs that should be merged before this[#3238572]#comment-14295003 |
| Rajab Natshah |
Almost tested after all MRs |
| Rajab Natshah |
The Project Browser has basic functionality NOW :kissing_heart:+ categories + Basic filter (edited) |
| bnjmnm |
Be sure to run update.php - a big part of the functionality I added requires some update hooks to fire |
| Rajab Natshah |
@bnjmnm Yes. noticed all the new caching schema tables |
| Rajab Natshah |
What I'm doing is a real physical rebuild and test |
| Rajab Natshah |
I had a number of bash commands to test with + claro ...Add a default dev and test commands for testing Project Browser 1.0.x dev branch on Drupal 9 and Varbase 9 #45 |
| bnjmnm |
Also want to mention (though many potentially noticed) - the database cache has a serialized field that includes release data and several other fields that don't necessarily have their own columns. This means we're not stuck sorting/querying by just the columns that currently exist. It opens up the possibility to do things like adding a new computed "relevancy" column in an update hook. (edited) |
| timplunkett (he/him) |
There are two major uncommitted issues. They need some CSS help still. They are:#3240318: Streamline "teaser" (card) view of projects |
| Rajab Natshah |
Tim Plunkett (tim.plunkett) Directed me to the standard.I think he is right. we should follow the current stable release.Claro is not the default admin them yet!@chrisfromredfin I think we need to enable Claro and test with itNot sure if we could have a new automated test and set the Claro theme as the default admin theme.As the design is following with Claro design system and style guide. |
| chrisfromredfin |
I agree that we need to be testing against Claro - my thinking on it is that it's pretty close. |
| timplunkett (he/him) |
Unless we're doing visual regression testing (which Drupal CI doesn't support), I don't know how important it is which theme is installed during test runs |
| Rajab Natshah |
@timplunkett (he/him) I'm with that too. Should we test both Seven + Claro manually then?I hope that Claro will be stable soon and be enabled by default in Drupal core - standard profile. |
| timplunkett (he/him) |
#easy-out-of-the-box could use the help :smile: |
| timplunkett (he/him) |
When we were working on the CSS last week (which as I mentioned is not done) we were manually testing with Claro and Seven. It's really only about styling though, there are no other possible problems with markup or anything |
| chrisfromredfin |
Thanks for your thoughts on this! We use threaded discussions to keep things tidy inside the meeting, so I'm replying here to start that. |
| chrisfromredfin |
So @cathwaldron - a lot of this discussion around categories/categorization has been happening in the Site Builder Subcommittee meetings on Tuesdays. We have been considering a couple of taxonomies, but aren't quite sure what they should be... and it's proving to be a harder problem than one would think. Right now the responsibility for assigning the category lays at the maintainer's feet. One sub-initiative we hope to achieve is to open issues with maintainers to re-categorize their projects. However, to do that, we first need to clean up the categories that exist. Some should merge, some should be removed entirely, etc. The issue for that is here, with much of the discussion happening inside the spreadsheet as comments. #3240313: Decide on re-categorization of modules for Drupal.org Admittedly, I think people lately are feeling a bit defeated by this one and so it hasn't had many eyes lately. With that said, this is something we're definitely looking at more for phase II, so that may be another reason for less attention recently, as we focus on the MVP. |
| cathwaldron |
@chrisfromredfin Thank you for helping me understand where the taxonomy issue is being addressed. How might one suggest broadening the topic to a schema for coding modules, possibly by applying tags to a project as attributes to the entity? would provide a fresh start to the existing d.o. category issue and could be informed by what search terms are used now in web searches, not just on d.o. It would entail creating a standard set of labels, agreeing on what each one means, and then applying to all modules, would allow filtered views based on search without need to revise categories as a prior step. And would help improve google search for modules so puts less stress on PB to meet every need. And could be crowd-sourced to spread the workload. Not sure whether this fits in the category discussion. But if I worked up a proposal who would be interested in discussion? Should I hold off on this idea until Phase 2? |
| chrisfromredfin |
I think what you're describing is a new issue, but something of value. You could file it as an issue. I think how you describe it would be phase 2, because in phase 1 we cannot (will not) change any fields on drupal.org. |
| cathwaldron |
Agreed. It would be more important to have the right conceptual framework, then to create and validate the schema, then apply to modules. Until modules are coded with schema it would not make sense to change fields on drupal.org to enable filtering by schema terms. |
| cathwaldron |
@chrisfromredfin Thank you for engaging with me on this idea. I see lots of related good discussion in different threads from past meetings. Will think and research some more, write a proposal outline, and then seek guidance on whether / how / where to open an issue. I am new at this and very grateful for feedback. |
| chrisfromredfin |
Absolutely! And happy to be your touch point especially for questions like "now what should I do" :slightly_smiling_face: |
| AmyJune (volkswagenchick) |
sure thing |
| chrisfromredfin |
I tend to agree that that advanced filter icon is not intuitive, even though it's Google / material design (it happens in Gmail), I don't think it's obvious enough. I think this is more of a known Drupal pattern: |
| AmyJune (volkswagenchick) |
#3251092: Spelling error in Advanced Filtering Options view |
| leslieg |
Feedback from the listening sessions (interviews) was consistent with what AmyJune is saying about advanced search not being clear in existing design |
| chrisfromredfin |
I love that we have actual interviews to validate that. |
| leslieg |
Yes, very helpful feedback and we have more interviews scheduled. Including with folks from the NEDCamp BoF on product details page |
| timplunkett (he/him) |
@AmyJune (volkswagenchick) I commented on the issue, but it's a Figma-only typo |
| timplunkett (he/him) |
+1 on the filtering icon being insufficient. |
| bnjmnm |
I just did some light accessibility testing of that filtering UI pattern in my Gmail account and it's not that great so ++1. I often run into accessibility problems with Material UI. |
AmyJune (volkswagenchick), shaal, Rajab Natshah, bnjmnm, timplunkett (he/him), chrisfromredfin, cathwaldron, leslieg
Comments
Comment #2
NadiaFaucon commentedStatus change from "Active" to "Needs Review"
Comment #10
leslieg commentedComment #11
leslieg commentedComment #12
leslieg commented