A new bug was introduced with the code added to render_pane function for IPE in 7.x-3.10. If the user is attempting to perform in-place editing on the front page of a site, the destination is set to "front". This causes the following error to be thrown:

Notice: Trying to get property of non-object in node_page_title() (line 2200 of /modules/node/node.module).

This can be fixed by checking if the current destination is "front", and skipping the evaluation if it is. Please review the attached patch, or let me know if there's a more appropriate way to fix the problem. Thanks.

CommentFileSizeAuthor
panels-ipe_front_page_error-1.patch1.04 KBron_s
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ron_s created an issue. See original summary.

ron_s’s picture

ron_s CreditAttribution: ron_s commented
Related issues: +#2897658: Menu blocks disappear when editing/saving in the Panels IPE

Related patch: https://www.drupal.org/project/panels/issues/2897658

ron_s’s picture

ron_s CreditAttribution: ron_s commented

Just to clarify, this error is seen when using IPE + Mini Panels. The Mini Panels sub-module redirects the user to a separate page to perform modifications, and the page will have a ?destination=front query string. This is what generates the error.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet at The University of British Columbia commented

Thanks for the report @ron_s, I'm a bit leary of the solution, where is 'front' path coming from?

ron_s’s picture

ron_s CreditAttribution: ron_s commented

The front path is coming from the _panels_mini_ipe_editor function in the Mini Panels In-Place Editor module. This provides IPE functionality for mini-panels.

It creates a "Return to previous page" button that for the instance when on the front page, will have a destination = "front":

  if (isset($_GET['destination'])) {
    drupal_set_message(l(t('Return to the previous page'), $_GET['destination']) . '.');
  }

See:
https://git.drupalcode.org/project/panels_mini_ipe/-/blob/7.x-1.x/panels...
https://www.drupal.org/project/panels_mini_ipe

ron_s’s picture

ron_s CreditAttribution: ron_s commented

This patch still applies cleanly to the new 7.x-3.11 release.

Let me know if I can provide any further information, or if we should take a different approach to resolve this issue.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet at The University of British Columbia commented
Parent issue: » #3321791: Plan for Panels 7.x-3.12

Thanks @ron_s, I'll add it to the target for the next release.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet at The University of British Columbia commented
Parent issue: #3321791: Plan for Panels 7.x-3.12 » #3383032: Plan for Panels 7.x-3.13
joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented

triggered more tests