Hi,
I have a panel with visibility rules set for which node/view to display based on the url. I just noticed today that using ipe to edit the shared header text is causing all other views/nodes (besides the one being displayed while editing) to be deleted from the panel content settings.
I've come up with a workaround, but this is a major problem.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | 1069744-ipe-inaccessible-pane-placeholders.patch | 1.72 KB | merlinofchaos |
| #7 | panels-IPEdataloss-1069744-7-d7.patch | 2.31 KB | Elvar |
| #3 | 1069744-IPEdataloss-0-D6.patch | 2.16 KB | jumidi |
Comments
Comment #1
tustind commentedSecond this... @eatsleepdev, what's your workaround?
Comment #2
eatsleepdev commented@tustind,
The main reason I wanted to use visibility rules was so I could share a block of text across multiple pages. So instead, I added the text to one page and pulled it into the other nodes with some code that looks like this:
Load the node and panel content
Display the content. This content number is something you can get with print_r($display) (maybe theres a better way to get this number that I didn't realize)
Comment #3
jumidi commentedHi.
This patch fixes the bug. It prints all the "panes" even when they are not visible, but it marks them with other classes in order to show them with other appearance. Only users that have permissions to use "in place editor" can view those hidden panes.
TODO: use javascript to show-hide the marked (class="hidipe") panes.
Comment #4
jumidi commentedComment #5
sdboyer commentedoh. wow. this totally didn't occur to me when i wrote IPE. maaaajor problem. sorry it's taken so long to get to this. adding it to my plate now.
and, sorry, but #3 is not an acceptable solution, as including all rendered HTML is a potential security issue. even if it's not immediately visible, the content is still totally accessible. the approach i'll need to take is injecting the data for the panes into the form without ever showing them on the frontend, then doing some magic with positioning around invisible items.
Comment #6
overtune commentedIs there any progress on this issue?
Let me know if it's needs testing or something...
Comment #7
Elvar commentedI have rerolled jumidi patch against 3.3, for those who desperately need it. :-)
Comment #8
joel_osc commentedJust wondering if the posted patch is 'acceptable' or is more work being done on this. If more work is being done then the status of this should likely be changed.
Comment #9
kasperg commentedAs sdboyer stated in #5 the posted patches are not acceptable solutions - rerolled or not. Reverting to needs work.
Comment #10
merlinofchaos commentedHere is an acceptable alternative.
Comment #11
beeradb commentedI tested this with the latest build of Panopoly and it looks good. I was able to verify the pane deletion before the patch, and post-patch I see the empty placeholder for the pane in the IPE and the pane is retained after saving.
Marking RTBC.
Comment #12
Taxoman commentedSuch a serious issue needs more reviews.
Comment #13
sylus commentedWorks for me as well ^_^
Comment #14
mgiffordThe patch applies nicely to the git repo. I don't know panels well enough yet to effectively test this though.
Would be great to get this into dev.
Comment #15
populist commentedThis also works for me and marking RTBC since we have a few different people reviewing which hopefully addresses the concerns in #12. Data loss is no good and would love to see this rolled in soon.
Comment #16
merlinofchaos commented