Storage type remains the same after saving layout as bundle default [#2864607]

When you set layout to bundle default storage id gets changed to [entity_type]:[bundle]:default, but storage type remains "panelizer_entity" which isn't correct. Later when you try to edit this display it will check access using panelizer_entity_panels_storage_access which expect storage id to have entity id and you'll get access denied. Apparently we need to add code that changes storage type after saving display as default so it checks for access using panelizer_default_panels_storage_access.

Comment	File	Size	Author
#2	panelizer-storage_type_issue-2864607-1.patch	463 bytes	sickness29
#2	7.x-3.x: PHP 5.3 & MySQL 5.5, D7 45 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

28 March 2017 at 08:24

sickness29 created an issue. See original summary.

Comment #2

sickness29 CreditAttribution: sickness29 commented 28 March 2017 at 08:27

File	Size
panelizer-storage_type_issue-2864607-1.patch	463 bytes
7.x-3.x: PHP 5.3 & MySQL 5.5, D7 45 pass

Patch for the issue.

Comment #3

sickness29 CreditAttribution: sickness29 commented 28 March 2017 at 08:27

Status:

Active

» Needs review

Comment #4

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 28 March 2017 at 17:30

Status:	Needs review	» Needs work
Issue tags:		+Needs tests

That's an interesting bug, thanks for providing a patch.

I think we'll need to put together tests to confirm the bug and confirm the patch fixes it.

Comment #5

Jorrit CreditAttribution: Jorrit at nCode for DOM Digital Online Media GmbH commented 29 March 2017 at 07:26

I can reproduce the problem and confirm that this patch fixes the problem.

Comment #6

Jorrit CreditAttribution: Jorrit at nCode for DOM Digital Online Media GmbH commented 29 March 2017 at 07:36

@sickness29: do you have time to add a test to panelizer.node.test?

Comment #7

aubjr_drupal CreditAttribution: aubjr_drupal commented 11 April 2020 at 18:06

Extremely late response on this, but I've had to fix this issue in many databases across sites (after a database update in Panopoly that addressed other issues).

If nobody added a test to panelizer.node.test yet, and it'd mean that this gets ported into Panelizer as a patch upstream for sure, I'd be willing to give it a shot. Is that's all that is holding this up (no .test update)?