Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Refactor openpublic_defaults into many sub modules or otherwise deal with it.
Or burn it with fire.
Comment | File | Size | Author |
---|---|---|---|
#9 | Screen shot 2014-07-10 at 2.50.26 PM.png | 19.47 KB | hefox |
#9 | Screen shot 2014-07-10 at 2.50.05 PM.png | 25.03 KB | hefox |
#6 | 2060595-openpublic-filter-6.patch | 37.87 KB | hefox |
#5 | 2060595-openpublic-filter-5.patch | 37.36 KB | hefox |
#4 | 2060595_openpublic_filters-4.patch | 48.14 KB | hefox |
Comments
Comment #1
hefox CreditAttribution: hefox commentedHere's patch one of the process; moving wysiwyg, anything with formats, imce into openpublic formats. Could manage it further by splitting into 3 (wysiwyg, formats, imce), but not sure whether that's worth it. Level of detail and usability to layman vs. developer, etc.
branch is 7.x-2060595
Comment #2
hefox CreditAttribution: hefox commentedAfter thinking it through more, it made sense to seperate wysiwyg/imce from text format as depedency issue; need filtered html/full for various exports including node and default content
Comment #3
hefox CreditAttribution: hefox commentedforgot to move make file
Comment #4
hefox CreditAttribution: hefox commentedWith the latest features, undefined permissions are caught and warned about then ignored, but otherwise the feature is installed as normal.
So this patch combines the ^ and removes the dependencies (via features exclude), then adds them back into the profile .info. This way things like search can be disabled without loosing the rest of the default config.
Comment #5
hefox CreditAttribution: hefox commentedMessed up rolling patch
Comment #6
hefox CreditAttribution: hefox commentedmissed adding the wysiwyg make file
Comment #7
hefox CreditAttribution: hefox commentedIgnoring previous patches
Current state of openpublic defaults
api.inc = contains openpublic_defaults_requirements_api, which is only hook implementing openpublic_api's hook_requirments_api. Move to openpublic.profile?
context.inc = contextes -- move to module just about layout?
theme.inc = lot of theme overrides; shouldn't this be in the theme? why are they seperate?
strongarm.inc = some default variables.
Comment #8
hefox CreditAttribution: hefox commentedComment #9
hefox CreditAttribution: hefox commentedtheme.inc
block themeing
It overrides the default block themeing to make these changes
So, addition of section-content, which is only referenced in the old openpublic_theme and changing blocks to use h3 instead of h2 and adding the rss link. This should likely be done on the theme layer, though $rss
RSS is set via
It's looking for a hard coded feed named feed_1 (default display id for first feed) and adding a link to it based on that. IMO that really should be refactored -- views have a feed setting -- use it. Harder to get into the title of the block (since block title is seperate from block content), but likely can position it similar to current (if really needed), and the theme really should be one handling this.
press release, event (new), and blog have feeds.
However, it looks like openomega is using it's own block theme (or it's parent theme) so this theme override isn't even taking effect with default openpublic install (which also means link to blog/press release rss isn't there).
block-follow
Changes to
This again likely should be on the theme layer -- purely css and sprites (well and configuring the block subject), not a theme override likely unless it's an accessibility thing.
Comment #10
hefox CreditAttribution: hefox commentedAddthis
This is only used in openpublic_theme.
Search term addition
It adds the term the user searched for to the page.. but that terms already in the search box -- really needed?
Search result author
Adds some variables that are again only used in openpublic_theme
A class that only exists in openpublic_theme
At bottom of file is actually not "theme" but blocks that are placed via contextes (in openpublic_default). They display menus. then there's a few more misc things like max 5 lines each
so summery of theme.inc
Comment #11
e2thex CreditAttribution: e2thex commentedApi.inc can be moved in to openpublic.profile
Comment #12
hefox CreditAttribution: hefox commentedContextes:
* move to a layout module,
* move stuff like media to associated module
nav_breadcrumb_title -- do we need this?
Fix the media_room nodeblock missing issue
nav_leader/nav_staff -- merge to one for staff-directory (field removed)
no_sidebars -- kill it (just for projects app)
open_government -- where page 'open' went
See if can set context weights via context (https://www.drupal.org/node/1605186) and mere side wide after/before
Move: share stuff to a share configuration feature
Comment #13
hefox CreditAttribution: hefox commentedComment #15
e2thex CreditAttribution: e2thex commentedComment #23
hefox CreditAttribution: hefox commentedIt's dead