Section Notification Override Cannot be Removed [#2686609]

Note: I'm using commit b27f331 of oa_notifications.

I have a Document section with default notifications that were overridden before updating to 2.60-rc1. When I deselect the Override default space notifications check box for that section, the inherited parent Space settings appear. But when I click Save, then return to edit the section again, the Override default space notifications check box is selected again and the parent Space notifications do not appear.

Also, when I deselect the Override default space notifications check box and the inherited Team ABC appears from the parent Space, if I click Expand all beneath it, the Team and expand link disappear altogether.

Comments

Comment #1

13 March 2016 at 20:14

thekenshow created an issue. See original summary.

Comment #2

dpoletto CreditAttribution: dpoletto commented 14 March 2016 at 12:41

Does Section's Comment Options setting report "Open" or "Closed" (if Section Page's Comments are Enabled into /admin/openatrium/setting)?

If Section Page's Comments are disabled the Default Notifications' "Override default space notifications" setting looks impossible to enable.

If I recall well on a Atrium site pre-2.60-rc1, where Default Notifications seems to work, the requirement is to have user subscribed to the content/space and not worrying if Section Page's Comment are Enabled or Disabled globally (I may be wrong...) since the important thing is that contents should have Comments enabled.

*Once* Section Page's Comments are Enabled there seems to be two scenarios:

-Section's Comment Options set to "Closed" -> the Default Notifications' "Override default space notifications" setting was impossible to enable.
-Section's Comment Options set to "Open" (Enabled = Users with the "Post comments" permission can post comment.") -> the Default Notifications' "Override default space notifications" setting worked (it lets us to adapt notification settings for that specific Section overriding its Space defaults)

*but* then, if you want to go back by removing added users/groups/teams and disabling it, it removes users/groups/teams but it doesn't disable itself and the check-box remains ticked. No matter what you do.

Comment #3

thekenshow CreditAttribution: thekenshow commented 14 March 2016 at 14:01

Comments were disabled for Sections, Spaces and Documents. I’ve enabled them and tried both Open and Closed settings on the Section, but the behaviour is the same:

1. Edit Section node with Override notifications selected and User A configured to notify.
2. Deselect the Override notifications check box, causing the default space configuration to appear (Team B in my case).
3. Save the Section, return to editing and the Override notifications check box is selected again, Team B does not appear, and User A is back for notification.

Is there supposed to be any interaction between Comments and Notifications in OA?

Comment #4

dpoletto CreditAttribution: dpoletto commented 14 March 2016 at 14:22

It's what I'm trying to figure out. Note: I'm on Atrium 2.60-rc1 (stock), no patch on oa_notifications yet.

Comment #5

mpotter CreditAttribution: mpotter commented 14 March 2016 at 15:42

dpoletto: You *must* use the dev version of oa_notifications. Several bugs (including the one you mention in #2) have already been fixed.

thekenshow: still working on the issue reported in #3.

The interaction between Comments and Notifications is that when you are viewing a node (not editing) the Notifications boxes are enabled if you are allowed to add comments (triggering a reply notification). The bug that was already fixed in dev was also looking at comments even on a node/edit/add form. With the latest dev the notifications should be shown in an edit/add form regardless of comment settings.

Comment #6

mpotter CreditAttribution: mpotter commented 14 March 2016 at 16:13

Status:

Active

» Fixed

OK, I think this is fixed in commit a82f29c for oa_notifications. Grab the latest dev of oa_notifications and let me know.

Comment #7

thekenshow CreditAttribution: thekenshow commented 14 March 2016 at 16:57

Installed a82f29c of oa_notifications, cleared caches, but still seeing problems:

1. Start with Override default space notifications selected, User A configured to notify.
2. Deselect Override - User A remains visible, Space A defaults do not appear.
3. Save, edit again - Override is selected again, and User A is configured to notify.
4. Deselect Override and this time remove User A. Space A defaults still do not appear.
5. Save, edit again - Override is selected again, and nothing appears configured to notify.
6. Save, edit again, no change - Override is selected again, and nothing appears configured to notify.

My console shows the following when I view this section node - related?

[Error] Failed to load resource: the server responded with a status of 404 (Not Found) (underscore-min.map;, line 0)
[Error] Failed to load resource: the server responded with a status of 404 (Not Found) (angular.min.js.map, line 0)

Comment #8

mpotter CreditAttribution: mpotter commented 14 March 2016 at 17:10

OK, I can reproduce #7. FYI, it's really important to mention if using notifications on a new Create node page, or when Editing a node, or when Viewing a node. The notification system is super complex and each of those 3 cases is different code (even though it looks the same to the user). Thank the ridiculous Drupal Form API Ajax handling for the complexity.

Anyway, I guessed that you were using the Edit page for the Section (although the original bug was on the Create node page). And there I was able to reproduce, so will try to get this fixed soon.

Thanks for the help getting this cleaned up in time for the 2.60 stable release later this week.

Oh, and I don't think those underscore-min errors are related. I think your browser console is looking for a map file for the js code so it can show it within the minification, but not all the js libraries provide the map files.