Problem/Motivation

ApiSpecificationController sets options on the generator, fetched from the query string. Some plugins, such as json:api, set options in their constructor. These are set during the parameter upcasting, and then overwritten with an empty array in the controller. Options from the request/query string should be merged in (and overwrite any defaults) instead of overwriting the options with an empty array if none are provided.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork openapi-3222266

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bradjones1 created an issue. See original summary.

bradjones1 opened merge request !1

bradjones1’s picture

bradjones1
Primary language English
commented
Status: Active » Needs review
Related issues: +#2942052: The Controller $options value should be stored as a property., +#3000458: Exclude disabled JSON API resources

e0ipso made their first commit to this issue’s fork.

  • e0ipso committed 21dcf82 on 8.x-2.x authored by bradjones1 
    Issue #3222266 by bradjones1: Merge options instead of overwriting
e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Status: Needs review » Fixed

This makes sense. Thanks for the contribution!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.