Closed (fixed)
Project:
OpenAPI
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
18 Sep 2018 at 06:16 UTC
Updated:
2 Jul 2019 at 17:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
e0ipsoThis can potentially fail tests. We'll see…
Comment #3
e0ipsoComment #5
e0ipsoFYI I'm not actively working on the tests.
Comment #6
jaapjan commentedConfirming the patch works with 2.x branch of jsonapi and openapi_ui_redoc:8.x-1.0-rc2. Since jsonapi_extras doesn't work yet with jsonapi 2.x we've implemented some custom code to only allow some entities for now.
Comment #7
arlina commentedPatch in #2 works against openapi 8.x-1.0-beta2, using jsonapi 8.x-2.4 and jsonapi_extras 8.x-3.5. It no longer shows the disabled resources.
Comment #8
e0ipsoI'm hoping that Rich can review this. It would be great to get this committed.
Comment #9
richgerdesI was working on a related patch for excluding disabled fields in schemata (#2882269: Support for JSON API's ResourceType::getPublicName() and ResourceType::isFieldEnabled()). I think that it would be best to implement this there, since schemata is used in jsonapi (contrib) to test validity of schema, and it makes sense to pull in schema without alterations in order to provide a consistent export of schema.
I was working on the related schemata patch last week during sprints at DrupalCon Seattle. I will finish up the updated patch and work this functionality into it, since its most relevant there.
I think this may be a duplicate of #2882269: Support for JSON API's ResourceType::getPublicName() and ResourceType::isFieldEnabled(), but leaving it open for now since this one has a patch.
Comment #10
e0ipsoThis issue is about disabled resources, the ones linked seem to be about disabled fields.
Comment #12
richgerdesPatch passed tests and looks good. It's been committed and pushed.