Need to document source of polyfills from https://git.drupalcode.org/project/olivero/-/blob/8.x-1.x/js/polyfills.e...

From #3111409: Add new Olivero frontend theme to Drupal 9.1 core as beta

CommentFileSizeAuthor
#7 3165454-7-polyfill-lic.patch1.21 KBmherchel
#2 3165454-add-todo.patch460 bytesproeung
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mherchel created an issue. See original summary.

proeung’s picture

proeung
she/her
CreditAttribution: proeung as a volunteer commented
Status: Active » Needs review
FileSize
3165454-add-todo.patch460 bytes

Here's the patch for adding a todo to remove the polyfills once #3143465: Add NodeList.forEach polyfill to support IE11 has landed into Core.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel at Lullabot commented
Assigned: proeung » Unassigned
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel at Lullabot commented
Status: Needs review » Needs work

I think you submitted a patch for the wrong issue! This is to document the source/license of the polyfills.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs work » Active

Do you want someone to document what's listed in https://git.drupalcode.org/project/olivero/-/blob/8.x-1.x/package.json?

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel at Lullabot commented
Issue summary: View changes

Nope. We need to add code comments to https://git.drupalcode.org/project/olivero/-/blob/8.x-1.x/js/polyfills.e...

Updating summary.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel at Lullabot commented
FileSize
3165454-7-polyfill-lic.patch1.21 KB

Patch attached.

  • mherchel committed ec8a120 on 8.x-1.x 
    Issue #3165454 by mherchel: Document source and license of polyfills
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
CreditAttribution: mherchel at Lullabot commented
Status: Active » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.