There are some bugs in this module. It would be better to change the status of og_menu to a lower level maybe beta until these things are fixed...

1.) it's only working with the content type "pages"
2.) the module shouldn't be triggered on non organic group posts
3.) the module shouldn't be triggered for admin
4.) #544446: Permissions allow access to all OG menus isn't fixed

I made a patch for 1,3 and 4 but i have no solution for 2.. I'm new to drupal development so help me out a little...!

CommentFileSizeAuthor
#4 og_menu.patch2.06 KBmuschpusch
og_menu.patch2.01 KBmuschpusch

Comments

jide’s picture

jide commented

That's a really great initiative mushpusch, I hope maintainers will react to this.

jide’s picture

jide commented

I'll try to find some time to help with 2) if I can.

jide’s picture

jide commented

for 1), in the og_menu_form_alter() function, it may be better to do like this :

if ($form['#id'] == 'node-form' && $form['menu']) {
muschpusch’s picture

muschpusch commented
StatusFileSize
new og_menu.patch2.06 KB

Hey Jide, thanks for 1).... inspecting the $form module i also found a solution for 2.)

if ($form['#id'] == 'node-form' && $form['menu'] && is_array($form['og_invisible'])) {

Do you know how to get CVS access to commit the changes? I'm getting the idea that this module is not maintained anymore....

jide’s picture

jide commented

@muschpusch : see http://drupal.org/node/251466. I am with you if you want to become the maintainer of the project ! But I think It could need a more deep rewrite.

jide’s picture

jide commented

I wrote to the maintainer via his contact form, let's see if he answers.

muschpusch’s picture

muschpusch commented

He Jide... i'm not sure if i really can be the maintainer of the project because i'm relative new to drupal... It's ok for me when you help & review the code. There are a lot of patches for the module and some offer better solutions than my modifications. Maybe we could start with a chat meeting?

bricef’s picture

bricef commented

Nice work.

For 2 you can use the function og_get_types('group_post') to get all group_post content type. I had problems to apply your patch, can you follow the rules printed there : http://drupal.org/node/323 ?

bricef’s picture

bricef commented

I just saw that this patch can help for 2 http://drupal.org/node/483948.

jide’s picture

jide commented

Thanks for helping bricef. I am now co-maintainer of this module (though i did not really want to) and I must find some time to make at least a release that *works*. For the moment, the module is awfully broken. I am not sure this patch resolves the biggest issues, maybe I'll go for a complete rewrite, but I have to review all pending patches before. Any help will be appreciated !

jide’s picture

jide commented

Maybe the first move will be to correct the biggest issues, publish it as an alpha version or something, and then when I got time, make a complete rewrite.

bricef’s picture

bricef commented

I have to use this module on one of my website. I suggest to apply some patchs and test in order to correct some obvious bug. I can help if you want but i have no CVS account.

jide’s picture

jide commented
Status: Needs work » Needs review

Test the new 2.x branch.

jide’s picture

jide commented
Status: Needs review » Closed (won't fix)

Since the 2.x branch has been released, I close this issue. Feel free to reopen if the problem occurs again.