Improved block display [#1878472]

Currently, if a group has multiple menus, the OG menu: single block displays the first menu only. If you are viewing group content that is linked from any other menu, you still only see the first menu and not the menu that contains the current content. I will submit a patch that checks if the current page is in any one of the group menus and display that menu in the single block, otherwise if none is found, display the first OG menu.

Comment	File	Size	Author
#5	og_menu-improved_block_display-1878472-5.patch	8.79 KB	bulldozer2003
#5
#4	og_menu-default_menus_context_block-1878472-4.patch	5.52 KB	bulldozer2003
#4
#3	og_menu-single_menu_context_block-1878472-3.patch	1.67 KB	bulldozer2003
#3
#1	og_menu-single_block_better_context-1878472-1.patch	969 bytes	bulldozer2003
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

bulldozer2003

king/sire

CreditAttribution: bulldozer2003 commented 3 January 2013 at 01:19

Status:	Active	» Needs review
Issue tags:		+Needs committer feedback

File	Size
og_menu-single_block_better_context-1878472-1.patch	969 bytes

Comment #2

bulldozer2003

king/sire

CreditAttribution: bulldozer2003 commented 11 January 2013 at 17:54

Would it be better to add a new display for this? Leaving single block to display the first menu and an additional block for the context aware menu?

In my use case I realize that a new context aware block would be better than replacing the single block.

Comment #3

bulldozer2003

king/sire

CreditAttribution: bulldozer2003 commented 11 January 2013 at 22:02

File	Size
og_menu-single_menu_context_block-1878472-3.patch	1.67 KB

Here is a patch implementing a new single menu block that shows the OG Menu the current page belongs to, if any.

Question: would it be worth adding code to check if the single menu block is in use and hide this block if it is going to show the single menu again?

Comment #4

bulldozer2003

king/sire

CreditAttribution: bulldozer2003 commented 12 January 2013 at 00:17

File	Size
og_menu-default_menus_context_block-1878472-4.patch	5.52 KB

Ok here is an even better implementation.

Now a "default" menu can be selected on the group>menus page, if set, that is the menu that the single menu block will display.

Adds the contextual single menu block, that will display the appropriate OG context's menu that has a link to the current page.

Comment #5

bulldozer2003

king/sire

CreditAttribution: bulldozer2003 commented 14 January 2013 at 18:56

Title:

Better single menu block display

» Improved block display

File	Size
og_menu-improved_block_display-1878472-5.patch	8.79 KB

Here is a fully thought out implementation of my improved block displays.

og menu single block
- shows the "default" menu, or the first menu found
og menu context block
- show the menu that contains a link to the current page, otherwise nothing
og menu multi block
- displays the "default" menu at the top

To assign default menus, a new column was added to the group "list menus for %group" page. When og creates a menu for a group via the node checkbox, that menu is set default.

Comment #6

rv0 CreditAttribution: rv0 commented 17 January 2013 at 16:17

Status:

Needs review

» Needs work

Well, I could not apply to latest code so I just had a brief glance at the patch.
So correct me if I'm wrong:

The "og_menu_default_menus" variable setting puzzles me a bit.
I've worked on sites with 1000's of groups, that array will become huge.
This feels wrong. Would't a simple boolean in the og_menu table offer the same functionality at a fraction of the performance cost?

Comment #7

bulldozer2003

king/sire

CreditAttribution: bulldozer2003 commented 22 January 2013 at 22:24

Rethinking this, I could change the menu list to be a sortable table and menus could be stacked in the order the user wants them displayed. Multi menu block would display them in the user defined order and single menu would display the top menu, while context menu block behaves as I originally outlined.