Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
Copying previous day values into a field with an additional time slot disallows the possibility to remove values.
Steps to reproduce
1. Click on the 'Add time slot' option.
2. Choose the 'Copy previous day'.
The 'Remove' link is now hidden from the display.
Proposed resolution
Update part of the JS that adds display: none parameter to the link.
User interface changes
The 'Remove' link will be available on the form after copying the previous day's values to the field with an additional time slot.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | office_hours_3377718-remove-link.patch | 994 bytes | johnv |
| Screenshot from 2023-07-28 14-07-44.png | 34.74 KB | paulrad | |
| Screenshot from 2023-07-28 14-07-38.png | 34.51 KB | paulrad | |
| Screenshot from 2023-07-28 14-07-31.png | 43.16 KB | paulrad | |
Issue fork office_hours-3377718
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
paulrad CreditAttribution: paulrad at DevBranch commentedPrepared merge request that resolves the issue.
Comment #4
johnvHmm,
I do not see a difference.
In my installation, the Remove link is never hidden.
Did your installation have #3367013: Allow to remove values that weren't submitted installed already?
Comment #5
johnvComment #6
johnvMy comment #4 is not correct. I do see the problem.
But the proposed solution breaks the behaviour of the 'add time slot' link, when more slots are possible, then entered.
The attached patch fixes the problem on the calling level.
Comment #8
johnv