Configuration schema Incomplete for field.formatter.settings.office_hours [#3072276]

Problem/Motivation

The configuration schema for field.formatter.settings.office_hours is incomplete.

Proposed resolution

Update modules/office_hours/config/schema/office_hours.schema.yml with the remaining configuration options.

Remaining tasks

Write a patch
Review
Commit

User interface changes

None.

API changes

None.

Data model changes

None.

Comment	File	Size	Author
#2	3072276-2.patch	3.61 KB	idebr
#2	8.x-1.x: PHP 7.1 & MySQL 5.5, D8.7.6 1 pass
#2	3072276-2-test-only.patch	2.31 KB	idebr
#2	8.x-1.x: PHP 7.1 & MySQL 5.5, D8.7.5 2 fail

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

2 August 2019 at 15:04

idebr created an issue. See original summary.

Comment #2

idebr CreditAttribution: idebr at ezCompany commented 2 August 2019 at 15:10

Status:

Active

» Needs review

File	Size
3072276-2-test-only.patch	2.31 KB
8.x-1.x: PHP 7.1 & MySQL 5.5, D8.7.5 2 fail
3072276-2.patch	3.61 KB
8.x-1.x: PHP 7.1 & MySQL 5.5, D8.7.6 1 pass

Attached patch completes the configuration schema for the office_hours field formatter.

The test includes the change from #3064545: Missing Group Annotation for Kernel Test

Comment #3

2 August 2019 at 15:16

The last submitted patch, 2: 3072276-2-test-only.patch, failed testing. View results

Comment #4

johnv

Dutch

CreditAttribution: johnv commented 8 August 2019 at 09:40

Title:

Configuration schema for field.formatter.settings.office_hours is incomplete

» Incomplete Configuration schema for field.formatter.settings.office_hours

Comment #5

8 August 2019 at 09:52

johnv committed d23c9a9 on 8.x-1.x authored by idebr

Issue #3072276 by idebr: Incomplete Configuration schema for field....

Comment #6

johnv

Dutch

CreditAttribution: johnv commented 8 August 2019 at 09:52

Version:	8.x-1.x-dev	» 8.x-1.2
Status:	Needs review	» Fixed

Committed, thanks.

Comment #7

22 August 2019 at 09:54

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Comment #8

kaythay CreditAttribution: kaythay at Aten Design Group commented 28 March 2020 at 18:02

I noticed this was committed a while back but we're having trouble testing a module that relies on the latest release. Is there any chance a release including this commit can be published? Thanks!