The classes TermStorage and CommentStorage contain comments like this:


  use ContentEntityStorageTrait {
    // @todo Rename to doDelete for consistency with other storage handlers.
    delete as deleteEntities;
  }

Comments

stevector created an issue. See original summary.

stevector’s picture

stevector
he/him
commented
Issue summary: View changes
dixon_’s picture

dixon_
he/him
Primary language English
Location France
commented
Priority: Normal » Major

Bumping priority since this is a method rename that would be nice to have done before alpha.

jeqq’s picture

jeqq commented
Status: Active » Needs review

@dixon_ In core storage handlers we have delete() and doDelete() methods. We can't rename the alias deleteEntities to doDelete, this will cause an incompatibility error.

dixon_’s picture

dixon_
he/him
Primary language English
Location France
commented
Status: Needs review » Closed (won't fix)

Ok, fair enough.

dixon_’s picture

dixon_
he/him
Primary language English
Location France
commented
Status: Closed (won't fix) » Active

@jeqq Actually, could you please remove the related todo from the code then as well?

jeqq’s picture

jeqq commented
Status: Active » Fixed

I've removed todos.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.