Create issues for all @todo's in the code

do you simply mean that this ticket should stay open until all todos are resolved?

No, this issue can be closed once we've created separate issues here on d.o for all @todo's and removed those comments from the code. Your patch is right, just needs more of the same thing :)

I think it's also a good idea to drop-in all issues we create as part of this into a comment here, so it's easy to cross reference that all @todo comments got issues created for them.

@stevector Thinking more about this, should we instead perhaps place each // @todo Foo bar with @todo See http://drupal.org/node/xxx instead? I guess that would be clearer for contributors also looking at the code?

Then each referenced issue would be responsible for removing the @todo See http://drupal.org/node/xxx part...

Thoughts?

Reading the "inline {@link}" documentation is sounds like we should do this:

// @todo: {@link https://www.drupal.org/node/2596783 Provide more granular permissions}

Based on the below example from: http://manual.phpdoc.org/HTMLSmartyConverter/HandS/phpDocumentor/tutoria...

  /**
     * Text with an {@link http://www.example.com Inline Link to a Hyperlink} and an inline
     * link to {@link element()} displays without a break in the flow
     * (again, the parentheses in "element()" are only necessary
     * because it is a function)
     */
    function element()
    {
    }

Seems like a CI failure. I re-queued the patch.

1. +++ b/multiversion_ui/src/Routing/RouteSubscriber.php
   @@ -63,7 +63,10 @@ class RouteSubscriber extends RouteSubscriberBase {
   +            // @todo: {@link https://www.drupal.org/node/2596783 Provide more
   +            // granular permissions.}
   +
   +
   

   Single blank line should be enough.

2. +++ b/src/MultiversionManager.php
   @@ -76,7 +78,11 @@ class MultiversionManager implements MultiversionManagerInterface {
   +   * @todo: {@link https://www.drupal.org/node/2597337 Consider using the
   +   * nextId API to generate more sequential IDs.}
   +   *
   +   *
   +   * @link
   

   Double blank line seems unnecessary here.

3. +++ b/src/Workspace/SessionWorkspaceNegotiator.php
   @@ -26,7 +26,9 @@ class SessionWorkspaceNegotiator extends WorkspaceNegotiatorBase implements Work
   -      // @todo Review from a security perspective.
   +      // @todo: {@link https://www.drupal.org/node/2597464 Review from a
   +      // security
   +      // perspective.}
          $workspace_id = $_SESSION['workspace'];
   

   The line breaks here seem a bit strange :)

Thanks a lot Steve! This brings us one big step closer to the first alpha release!