If you disable the module under the modules administration page it does not insure that "Use mime mail for all messages" is unset.

CommentFileSizeAuthor
#2 mimemail.install.txt332 bytesdww

Comments

dww’s picture

Title: Disabling module does not completely disable the module » missing mimemail_uninstall() to remove all variables
Assigned: Unassigned » dww

I don't think you just mean disable, you must mean "uninstall". Yup, there's no mimemail_uninstall() implementation, so this module is "leaking" all of its variables:

mimemail_alter
mimemail_crlf
mimemail_engine
mimemail_incoming
mimemail_key
mimemail_textonly

This will be a trivial patch, stay tuned.

dww’s picture

Status: Active » Needs review
StatusFileSize
new332 bytes

Since there's no mimemail.install already existing, here's a raw copy of the new file, instead of a patch. Tested and works as expected. This is RTBC, but it's my own patch, so I'll let someone else decide that. ;)

sutharsan’s picture

Assigned: dww » Unassigned
Status: Needs review » Reviewed & tested by the community

Works as advertised.

Variable 'smtp_library' is set by mimemail and may have a value like "sites/all/modules/mimemail/mimemail.module". Leaving this variable untouched at uninstall should not cause a problem. drupal_mail_send() handles this correctly.

dww’s picture

Assigned: Unassigned » dww

Thanks for the review. This is still an issue I'm planning to see through to the end, so I'm keeping it assigned to myself. ;)

jerdavis’s picture

Version: 5.x-1.0 » 7.x-1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed to HEAD, thanks!

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.