Closed (fixed)
Project:
Mime Mail
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
19 Mar 2008 at 22:43 UTC
Updated:
17 Aug 2008 at 07:21 UTC
Jump to comment: Most recent file
If you disable the module under the modules administration page it does not insure that "Use mime mail for all messages" is unset.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | mimemail.install.txt | 332 bytes | dww |
Comments
Comment #1
dwwI don't think you just mean disable, you must mean "uninstall". Yup, there's no mimemail_uninstall() implementation, so this module is "leaking" all of its variables:
mimemail_alter
mimemail_crlf
mimemail_engine
mimemail_incoming
mimemail_key
mimemail_textonly
This will be a trivial patch, stay tuned.
Comment #2
dwwSince there's no mimemail.install already existing, here's a raw copy of the new file, instead of a patch. Tested and works as expected. This is RTBC, but it's my own patch, so I'll let someone else decide that. ;)
Comment #3
sutharsan commentedWorks as advertised.
Variable 'smtp_library' is set by mimemail and may have a value like "sites/all/modules/mimemail/mimemail.module". Leaving this variable untouched at uninstall should not cause a problem. drupal_mail_send() handles this correctly.
Comment #4
dwwThanks for the review. This is still an issue I'm planning to see through to the end, so I'm keeping it assigned to myself. ;)
Comment #5
jerdavisCommitted to HEAD, thanks!
Comment #6
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.