Not sure if i'm doing something wrong here, but, i've set the status to "2" for all the entries in the migrate_map, and then I only have 1 item marked as 'needs_update' (=1)

./includes/map.inc:  const STATUS_IMPORTED = 0;
./includes/map.inc:  const STATUS_NEEDS_UPDATE = 1;
./includes/map.inc:  const STATUS_IGNORED = 2;
./includes/map.inc:  const STATUS_FAILED = 3;

what the table looks like

mysql> select count(*), needs_update from migrate_map_articlexml group by needs_update;
+----------+--------------+
| count(*) | needs_update |
+----------+--------------+
|        1 |            0 |
|     6000 |            2 |
+----------+--------------+
2 rows in set (0.01 sec)

however it seems to try to update all the 6001 entries, if i restrict it to just 5, after i click submit i get the follow (5995 are now set to needs_update =1 (needs update))

mysql> select count(*), needs_update from migrate_map_articlexml group by needs_update;
+----------+--------------+
| count(*) | needs_update |
+----------+--------------+
|        5 |            0 |
|     5995 |            1 |
|        1 |            2 |
+----------+--------------+
3 rows in set (0.01 sec)

I am clicking the "[ ] Update" checkbox and entering '5' in the limit box

ideas?

CommentFileSizeAuthor
#2 migrate-ignored_rerun-1529362-2.patch543 bytesmikeryan

Comments

dgtlmoon’s picture

dgtlmoon commented

Sorry, first is set to "needs update" = 1


mysql> select count(*), needs_update from migrate_map_articlexml group by needs_update;
+----------+--------------+
| count(*) | needs_update |
+----------+--------------+
|        1 |            1 |
|     6000 |            2 |
+----------+--------------+
2 rows in set (0.01 sec)

but i'm still seeing the same problem

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Active » Needs review
StatusFileSize
new migrate-ignored_rerun-1529362-2.patch543 bytes

Does the attached patch work for you (prevent the ignored rows from being rerun)?

Thanks.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Needs review » Fixed

Committed to D6 and D7.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Fixed » Needs work

Oops! See #1538046: Row highwater field is checked unprepared - sourceid1 actually isn't populated in the row, so this patch continues to cause excessive rerunning.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Assigned: Unassigned » mikeryan
Status: Needs work » Fixed

OK, I've changed things to make sure the sourceids get put into the map row, and also fixed a highwater logic bug that was exposed by the first change.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.