Problem/Motivation

The "menu-" convention only applies to custom menus created through the web UI. On migrations, the menu machine names likely don't begin with menu as in my case.

This would only affect existing menus when the module is enabled.

Proposed resolution

use menu_get_names(FALSE) to get all custom menus. The false parameters filters off system menus. Then remove the check for menu names beginning with "menu-"

Remaining tasks

I will attach a patch.

User interface changes

None

API changes

None

CommentFileSizeAuthor
#1 update-only-finds-some-custom-menus-1263630.patch668 bytesjohnbarclay
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

johnbarclay’s picture

johnbarclay CreditAttribution: johnbarclay commented
FileSize
update-only-finds-some-custom-menus-1263630.patch668 bytes

patch attached.

JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin commented
Status: Active » Needs work

I can't alter an existing update function. A fix would require a new update function.

Also, is this needed now that Drupal core is fixed?