For some reason I've noticed that media_brightcove_emfield_providers() throws warnings on all calls when $provider is not 'brightcove'.

CommentFileSizeAuthor
#1 media_brightcove-n711586.patch1.21 KBDamienMcKenna
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Active » Needs review
FileSize
media_brightcove-n711586.patch1.21 KB

Here's a patch that adjusts the function slightly:

  • Adds some extra comments explaining what's going on.
  • Only does the drupal_system_listing() call if $provider == 'brightcove'.
  • Stores the discovered path as a static variable incase it gets executed again.
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented

FYI this is related to #222074: PHP bug/feature in array_merge_recursive() causes warning messages.

aaron’s picture

aaron CreditAttribution: aaron commented
Status: Needs review » Fixed

fixed. thanks, @damien!

aaron’s picture

aaron CreditAttribution: aaron commented

oops, forgot to check for the null case... fixed that too.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 2a95426 on 6.x-1.x, 6.x-2.x, 7.x-2.x by aaron: 
    #711586 by DamienMcKenna: Resolve PHP warning in...
  • Commit 93ece0e on 6.x-1.x, 6.x-2.x, 7.x-2.x by aaron:
    #711586 by aaron: Fix provider for null case.