It looks like the code expects that if the matrix field has a fixed number of rows specified, there should always be an extra empty header cell added to the table (i.e. an empty cell gets added to row 0, column 0). Unfortunately, this is only a safe assumption if row labels have been specified. If they haven't, the result is that the rendered table has one more column than the data rows actually have (since the labels don't render).

Additionally, if a fixed number of rows is specified for the matrix field, but not all rows have data, the extra rows look really ugly in the rendered table.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

GuyPaddock’s picture

The attached patch addresses both of these issue.

GuyPaddock’s picture

Status: Active » Needs review

Setting to NR.

intrafusion’s picture

Status: Needs review » Fixed

Thanks for your input on this and several other issues, your patch has been added to the module

GuyPaddock’s picture

Status: Fixed » Needs review
FileSize
1.33 KB

Had to add on to this patch... saw side effects with tables that have one column and row labels.

An additional patch is attached.

intrafusion’s picture

Status: Needs review » Fixed

Thanks for this update, this has been applied to the module

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.