$this->t() method should be used instead of t() function in classes where StringTranslationTrait trait used.

CommentFileSizeAuthor
#8 mailchimp-added_t_method-3031832-8.patch5.47 KBi-trokhanenko
#5 3031832-4.patch51.14 KBknyshuk.vova
#2 3031832-2.patch7.28 KBknyshuk.vova

Comments

knyshuk.vova created an issue. See original summary.

knyshuk.vova’s picture

knyshuk.vova commented
StatusFileSize
new 3031832-2.patch7.28 KB

Please review.

knyshuk.vova’s picture

knyshuk.vova commented
Assigned: knyshuk.vova » Unassigned
Status: Active » Needs review
knyshuk.vova’s picture

knyshuk.vova commented
Status: Needs review » Needs work
knyshuk.vova’s picture

knyshuk.vova commented
StatusFileSize
new 3031832-4.patch51.14 KB

Replaced more things in this patch. Please, review the patch.

knyshuk.vova’s picture

knyshuk.vova commented
Status: Needs work » Needs review
samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
commented
Status: Needs review » Needs work
Issue tags: +Needs re-roll

Patch needs a re-roll.

i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented
Category: Bug report » Task
Status: Needs work » Needs review
StatusFileSize
new mailchimp-added_t_method-3031832-8.patch5.47 KB

Please review!

i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented
Roman Dyn’s picture

Roman Dyn commented
Status: Needs review » Reviewed & tested by the community

Patch #8 works fine for me. Please commit. Thanks!

  • i-trokhanenko authored 03d89a1 on 8.x-1.x 
    Issue #3031832 by knyshuk.vova, i-trokhanenko: Replace t() with $this->t...
samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.