Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.After joining a group, the message "You are now a member of Western Frisian team." on top of the screen contradicts the status "Your membership request awaits approval." displayed in the right sidebar. At the moment of writing this, I am not sure which of these messages is telling the truth, or how the D6 site behaves in this case.
Detailed steps I took to get here:
- log in (I am already member of one group, Dutch; I have no special privileges or roles afaik)
- open the "Frisian, Western" group page https://localize-7.staging.devdrupal.org/translate/languages/fy
- click the "Join" button in the right sidebar
- see the conflicting messages (see screenshot)
Expected result: all messages / statuses reflect the current situation correctly.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | Selection_014.png | 66.48 KB | marcvangend |
| #5 | Screenshot 2015-06-26 21.50.39.png | 48.33 KB | opdavies |
| Selection_012.png | 76.5 KB | marcvangend |
Comments
Comment #1
opdaviesI've updated the original issue (#2349693: Missing message after automatically joining a group).
Comment #2
Gábor HojtsyI think due to #2349587: Revoke ability to customize per group roles/permissions entirely group member pre-moderation should not theoretically be possible, so not sure how that happens(?). I think you should be a member when you join without moderation regardless of group. The Western Frisian team did not even use to moderate members on live (See https://localize.drupal.org/og join link instead of request membership).
Comment #3
marcvangendThat's interesting. Just to be clear: on the test site I still cannot add/suggest/edit translations for Frisian, so the "Your membership request awaits approval" status must be true.
Comment #4
Gábor HojtsyEven more interesting ;D
Comment #5
opdaviesI noticed yesterday that the default OG permissions were set for "Subscribe to group" (which requires approval) for non-members, rather than "Subscribe to group (no approval required)".
I've changed this on the Localize staging site, and will look into how to set this in code as the default option in case we decide to rebuild staging again at a later date.
Comment #6
marcvangendI checked again; this time I got the same message "You are now a member of Western Frisian team" and there was no status saying my membership is awaiting approval. However I am still not able to add or edit translations. Screenshot:
Comment #7
opdaviesYou're a full member of the group now, so it's not that.
I'm not sure which permission allows you to add or edit translations. I know that there's one called "Browse translations". I'll check what's enabled.
Comment #8
marcvangendMaybe it's good to mention that I can add and edit translations in the Dutch group, of which I already was a member. So it seems to me that it's not just a permissions problem, there must be group-specific settings involved I suppose.
Comment #9
Gábor HojtsyYeah people who join a team should have permission to submit suggestions (the suggestions themselves pending approval). This is governed by "Submit suggestions" permission. That is granted to "Translation team member" role. I suspect that role is not assigned to members when they join a group? While we may solve this by merging the "Member" and "Translation team member" roles, it would be ideal to keep the possibility to "ban" someone from the group, which is doable now by assigning the passive member role or not assigning any role at all other than "member".
In other words, member does not really grant you anything ATM and the "Translation team member" role should be granted on joining teams (automatically).
Comment #12
opdaviesNew group members now get the "Translation team member" role automatically when joining a group.
Comment #13
opdaviesComment #14
Gábor Hojtsy@marcvangend: can you verify this works now? Thanks!
Comment #15
marcvangendYes, it works as expected! Thanks.
Comment #16
opdavies@marcvangend: Great. Thanks!