Problem/Motivation

Using a link such as http://127.0.0.1:1/broken can't currently be checked.

This is because the code currently has a check for RequestException, however some links are simply rejected with a ConnectException.

Steps to reproduce

Try to check a link such as http://127.0.0.1:1/broken

Proposed resolution

Add a more global error catching mechanism. And rather than defaulting to 502, show the actual status code from the exception where possible (if it's status code 0, then show that rather than default to 502).

Remaining tasks

Provide MR.

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Comments

codebymikey created an issue. See original summary.

codebymikey’s picture

codebymikey commented

https://git.drupalcode.org/project/linkchecker/-/commit/ae54bc70519473ea... already tries to do something similar in its MR.

codebymikey’s picture

codebymikey commented
Related issues: +#3334240: Use GET method as fallback if HEAD fails
codebymikey’s picture

codebymikey commented
Status: Active » Closed (duplicate)
Related issues: +#3469263: Links never checked

Duplicate of #3469263: Links never checked

Closing

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.