Links with ? in URLs are converted to &

@chaunceyt Your patch fixed another issue for me. (Duplicate query params.)
See https://www.drupal.org/node/1646360 for similar issue.

Thanks!

Remember folks - if you post a patch to fix a problem, set the status of the issue to "Needs Review".

If you've tested a patch and agree that it fixes the problem, then set the status of the issue to "Reviewed & Tested by the Community."

Hey @chaunceyt, can you give me more information about how this field is setup and being displayed? I've got an automated test that checks that a link with a querystring shows up normally.

If you could give me more information about the specifics of this field - how it's configured - and how it's displayed, that would help.

(I notice this ticket is two years old, so I realize you may not reply.)

I have a similar issue with proxy sites.

http://proxy.kclibrary.org/login?url=http://infotrac.galegroup.com/itweb...
is displayed as
http://proxy.kclibrary.org/login?url=http%3A//infotrac.galegroup.com/itw...

// Separate out the query string, if any.
if (strpos($url, '?=this-alters-my-output') !== FALSE) {
    $query = substr($url, strpos($url, '?') + 1);
    $url_parts['query'] = _link_parse_str($query);
    $url = substr($url, 0, strpos($url, '?'));
  }
  $url_parts['url'] = $url;
  return $url_parts;
}

@jeffwpeterson - So, the url in question has two ? in it? Well, then it should be doing this - per the internet standard, any ? in a url that isn't indicating that there's a querystring should be encoded. Does the url with the encoded second ? work properly?

(Of course, a lot of websites don't pay attention to the standards.)

(entered url) http://proxy.kclibrary.org/login?url=http://infotrac.galegroup.com/itweb...

(result url) http://proxy.kclibrary.org/login?url=http%3A//infotrac.galegroup.com/itw...

http://beta.kclibrary.org/research-resources/research-databases/chiltonl...

In the result url the second ":" is converted to "%3A" after the "?" of the query string. There are not 2 "?";

The entered url works properly from inside the library. The result url throws an error.
This is a proxy filter that allows only url's initiated from inside our system to access that database. It is a standard in libraries as far as I know.

J.

I have the same problem with ":" converted to "%3A" (https://www.drupal.org/node/1984398#comment-9352247) . My Link module version is 7.x-1.3.
Url : http://bookshop.europa.eu/uri?target=EUB:NOTICE:KE6805058:EN:HTML
Displayed URL : http://bookshop.europa.eu/uri?target=EUB%3ANOTICE%3AKE6805058%3AEN%3AHTML

I also have this issue. Proxy for a library. I have to http://'s in the URL. The second one gets encoded and won't pass through the proxy. Has anyone come up with a fix for this?

I have the problem where ( ) converted to %28 %29 im using 7.x-1.3
Update: ( ) converted only when the " ? " used. by removing " ? " for test purposes the ( ) are in place.

for example the link: http://www.website.com/click?p(123)a(123456)g(123456789)
converts to: http://www.website.com/click?p%28123%29a%28123456%29g%28123456789%29

Hi,
Tradedoubler urls are also not validated, see also https://www.drupal.org/node/2407553
Is with this patch this validated?
Greetings, Martijn

I have tracked down the bug and think I can explain it more clearly now.

I have a url with a nested query string. The query string is a url itself.
"http://proxy.kclibrary.org/login?url=http://search.proquest.com/abicompl..."

The drupal url() function in the code below (line 518) is altering $url_parts['query'] incorrectly.

http://api.drupal.org/api/drupal/includes%21common.inc/function/url/7
'query': An array of query key/value-pairs (without any URL-encoding) to append to the URL.

  if (!empty($url_parts['url'])) {
    $item['url'] = url($url_parts['url'],
      array('query' => isset($url_parts['query']) ? $url_parts['query'] : NULL,
      'fragment' => isset($url_parts['fragment']) ? $url_parts['fragment'] : NULL,
      'absolute' => !empty($instance['settings']['absolute_url']),
      'html' => TRUE,
      )
    );
  }

So: http://proxy.kclibrary.org/login?http://search.proquest.com/abicomplete?accountid=37396
Becomes:http://proxy.kclibrary.org/login?url=http%3A//search.proquest.com/abicomplete%3Faccountid%3D37396 

This is not an issue in Drupal8. YAY!

See #1914072: Link Module displays malformed external URL

The patch does not address this issue.

The query string is being separated out and feed into the url(); function. The url(); function is the problem. See my comment #13 for details.

Also having trouble with proxy links. I see that the links on this page are working properly. Is there another fix available that has corrected the trouble with replacing question mark in the queried link?

https://www.kclibrary.org/topics/newspapers
http://proxy.kclibrary.org/login?url=http://search.proquest.com/chicagot...
http://proxy.kclibrary.org/login?url=http://www.bizjournals.com/kansasci...
http://proxy.kclibrary.org/login?url=http://search.proquest.com/newsstan...

Hi. I am trying to solve same issue for using EZProxy URLs. I see that the URLs being used at www.kclibrary.org are now working despite this issue. Jeff - Can you share how this was corrected?

This is also an issue with Drupal 8.5.5 and Link Module
URL --
http://ezproxy.library.selkirk.ca/login?url=http://selkirk.kanopy.com/
is converted to:
http://ezproxy.library.selkirk.ca/login?url=http%3A//selkirk.kanopy.com/

For EZproxy this may help. "EZProxy: Use qurl, not url, really"
https://bibwild.wordpress.com/2013/01/08/ezproxy-use-qurl-not-url-really/

I'm having the same issue with Drupal 8.5.5^

Is there a solution to fix this? Thanks!

Comment out part of this function to make proxy work.

function _link_parse_url($url) {
  $url_parts = array();
  // Separate out the anchor, if any.
  if (strpos($url, '#') !== FALSE) {
    $url_parts['fragment'] = substr($url, strpos($url, '#') + 1);
    $url = substr($url, 0, strpos($url, '#'));
  }
  /*
  // Separate out the query string, if any.
  if (strpos($url, '?') !== FALSE) {
    $query = substr($url, strpos($url, '?') + 1);
    $url_parts['query'] = _link_parse_str($query);
    $url = substr($url, 0, strpos($url, '?'));
  } */
  $url_parts['url'] = $url;
  return $url_parts;
}