Problem/Motivation

The "Disassociate All Translations" utility in the settings page does not work properly (only node translations *are* disassociated).
This is due to a small issue in getAllLocalDocumentIds().

Also, this only applies to content. Configuration documents are not disassociated.

Proposed resolution

Add tests that any kind of entity and configuration is disassociated.

Remaining tasks

Ensure the patch fixes this for all content entities.
Ensure we can fix the same for configurations.

User interface changes

None.

API changes

None (expected).

Data model changes

None (expected)

CommentFileSizeAuthor
#8 2783553-disassociate-all-translations-8.patch9.17 KBpenyaskito
#8 2783553-disassociate-all-translations-8.only-tests.patch8.46 KBpenyaskito
#8 2783553-disassociate-all-translations.interdiff.4-8.txt11.05 KBpenyaskito
#4 lingotek-disassociate_all_translations-2783553-4.patch9.17 KBpenyaskito
#4 lingotek-disassociate_all_translations-2783553-4.only-tests.patch8.46 KBpenyaskito
#2 lingotek-disassociate_all_translations-2783553-2.patch711 bytesazinck
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

azinck created an issue. See original summary.

azinck’s picture

azinck CreditAttribution: azinck commented
Status: Active » Needs review
FileSize
lingotek-disassociate_all_translations-2783553-2.patch711 bytes
azinck’s picture

azinck CreditAttribution: azinck commented
Issue summary: View changes
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented
Issue summary: View changes
FileSize
lingotek-disassociate_all_translations-2783553-4.only-tests.patch8.46 KB
lingotek-disassociate_all_translations-2783553-4.patch9.17 KB

Thanks for the patch!

This patch includes the previous fix + tests.

Also discovered that we are not disassociating configuration, only content.

The last submitted patch, 4: lingotek-disassociate_all_translations-2783553-4.only-tests.patch, failed testing.

The last submitted patch, 4: lingotek-disassociate_all_translations-2783553-4.only-tests.patch, failed testing.

The last submitted patch, 4: lingotek-disassociate_all_translations-2783553-4.only-tests.patch, failed testing.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented
FileSize
2783553-disassociate-all-translations.interdiff.4-8.txt11.05 KB
2783553-disassociate-all-translations-8.only-tests.patch8.46 KB
2783553-disassociate-all-translations-8.patch9.17 KB

Attaching patch that takes care of also disassociating the configuration translations.

The last submitted patch, 8: 2783553-disassociate-all-translations-8.only-tests.patch, failed testing.

The last submitted patch, 8: 2783553-disassociate-all-translations-8.only-tests.patch, failed testing.

The last submitted patch, 8: 2783553-disassociate-all-translations-8.only-tests.patch, failed testing.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented
Status: Needs review » Reviewed & tested by the community

Tests passed and failed as expected.

  • penyaskito committed 551c01b on 8.x-1.x 
    Issue #2783553 by penyaskito, azinck: Disassociating all translations...
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented
Status: Reviewed & tested by the community » Fixed

Committed 551c01b and pushed to 8.x-1.x. Thanks @azinck!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.