Leaflet provides this, why not include it?

CommentFileSizeAuthor
#4 popup-tip-problem.png40.75 KBokeedoak
#2 leaflet-fix-ie8-1830440-6756597.patch354 bytesgmclelland
oldie_support.patch403 bytestnightingale

Comments

pvhee’s picture

pvhee commented
Status: Active » Fixed

Great, committed

gmclelland’s picture

gmclelland commented
Status: Fixed » Active
StatusFileSize
new leaflet-fix-ie8-1830440-6756597.patch354 bytes

This needs one more line added. I noticed it was including the css in Chrome when it should only be applying the conditional for IE. Without this patch, Leaflet popup tips will look weird.

Patch is attached. Hope that helps. Thanks for making this great module!

ronan’s picture

ronan commented
Status: Active » Reviewed & tested by the community

I can confirm that this patch is necessary and works.

okeedoak’s picture

okeedoak commented
StatusFileSize
new popup-tip-problem.png40.75 KB

Here's what the problem looks like without the patch.
Pop tip problem

Patch solves the problem

pvhee’s picture

pvhee commented
Status: Reviewed & tested by the community » Fixed

Patch from #2 now committed, thanks!

okeedoak’s picture

okeedoak commented
Status: Fixed » Active

'!IE' => FALSE, is missing. Was the wrong patch committed?

pvhee’s picture

pvhee commented
Status: Active » Fixed

This is committed, but dev releases are only generated once a day if you don't use git.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.