
If dev-releases are used, the project version gets set to the latest stable release by using branch as version and "trusting the translation server to fall back to the latest stable release for that branch". This does not seem to work for local files though.
Example: admin_theme version 7.x-1.0+4-dev
Missing translation for 1 project:
Administration theme (7.x-1.x). File not found at https://ftp.drupal.org/files/translations/7.x/admin_theme/admin_theme-7.... nor at translations://admin_theme-7.x-1.x.de.po
Ironically, the file is listed under https://ftp.drupal.org/files/translations/7.x/admin_theme/, but not accessible. This part seems to be a server issue. Regarding the local file ... translations://admin_theme-7.x-1.0.de.po is there, but not found by the module.
Proposal: Instead of setting branch as version just strip dev-release information to get proper version info.
Examples from code:
7.x-1.x-dev => 7.x-1.x (no change)
7.x-1.0-alpha1+5-dev => 7.x-1.0-alpha1 instead of 7.x-1.x.
7.33-dev => 7.33 instead of 7.x
Thoughts about this?
Comment | File | Size | Author |
---|---|---|---|
#6 | l10n_update-improve_dev_release_fallback-2949027.patch | 1.54 KB | FireHawkX |
#2 | l10n_update-improve_dev_release_fallback-2949027.patch | 1.68 KB | rudi teschner |
Comments
Comment #2
rudi teschner CreditAttribution: rudi teschner commentedComment #3
rudi teschner CreditAttribution: rudi teschner commentedFixed typo in summary
Comment #4
FireHawkX CreditAttribution: FireHawkX commentedwill be testing this patch out today.
Comment #5
FireHawkX CreditAttribution: FireHawkX commentedpatch does not apply, path seems to be wrong and keeps all the directory structure from the author, i'll try to edit and reupload
Comment #6
FireHawkX CreditAttribution: FireHawkX commentedHere is the updated version that applies cleanly to latest dev 7.x-2.x
Out of my 200+ modules, the only two that didnt work were draggableviews because the version didnt match...
Also, update_extended-7.x-1.1, because the translation are marked with RC1 (release candidate) and it does not seem to be using those...
Overall, great patch and it works fine!
Thanks!