Closed (fixed)
Project:
JSON:API Resources
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
9 Dec 2020 at 19:59 UTC
Updated:
3 Jan 2021 at 22:59 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
auth commentedAttached patch implementing proposed resolution
Comment #3
marthinal commentedI found the same problem. I'm trying to understand if we need to refactor this. There is a Functional test testAddCommentResource() that executes a POST.
If I go to AddComment::process
We execute processEntityCreation() . If I go to that method I see this $response
I'm using commerce_api and we have different resources to update or add items and we always return createJsonapiResponse().
I think we can return CacheableResourceResponse if the method is cacheable
otherwise we can return ResourceResponse.
Comment #4
larowlanAdding the error message here for folks using duckduckgo etc
Comment #5
larowlanFixing coding standards
Comment #6
mglamanI want to get #3189198: Allow installation with Drupal 9 in quick, so we can test against 9.1
Comment #7
mglamanComment #8
mglaman🤦🏼♂️sorry, this module is OK not the module I was trying.
Comment #9
mglamanFixing D9 phpcs failures here: #3189204: Fix PHPCS, then re-running and merging.
Comment #10
mglamanCommitted the PHPCS fix and re-queued the test. Comitting once passed and tagging a release.
Comment #11
mglamanFixing deprecation. I don't know why 9.2 breaks, but 9.1 is good with this.
Comment #13
mglamanThank you all! Tagging a release.
Comment #14
larowlan🙏 merci beaucoup