Problem/Motivation

See #3004582-21: Make JSON API Extras 2.x (next release: 2.10) compatible with JSON API 2.0-beta2 for details.

Proposed resolution

Add ResourceTypeRepository::createResourceType().

Remaining tasks

Review.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#9 3006270-9.patch4.51 KBwim leers
#9 interdiff.txt1.43 KBwim leers
#4 3006270-4.patch3.15 KBwim leers
#4 interdiff.txt1.07 KBwim leers
#2 jsonapi_createresourcetype_1x.patch2.38 KBwim leers
#2 jsonapi_createresourcetype_2x.patch2.74 KBwim leers

Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new jsonapi_createresourcetype_2x.patch2.74 KB
new jsonapi_createresourcetype_1x.patch2.38 KB

The 1.x patch is entirely optional. IMHO we should not change this in 1.x. The 1.x change is also not necessary for #3004582: Make JSON API Extras 2.x (next release: 2.10) compatible with JSON API 2.0-beta2. It would make things nicer in jsonapi_extras, but relying on it still means that existing 1.x sites have to update jsonapi first, before they can update jsonapi_extras. This is not desirable.

The last submitted patch, 2: jsonapi_createresourcetype_2x.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
StatusFileSize
new interdiff.txt1.07 KB
new 3006270-4.patch3.15 KB

Failed for the missing docblock.

gabesullice’s picture

gabesullice
Primary language English
commented

+1 to the 2.x only patch.

I've had at the back of my mind for a while that perhaps we should have factories for all of our value objects.

Overriding or decorating those factories would then take the place of overriding normalizers. This is a step in that direction it seems.

Status: Needs review » Needs work

The last submitted patch, 4: 3006270-4.patch, failed testing. View results

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Needs review

CI job went missing. DrupalCI is drunk. Retesting.

Status: Needs review » Needs work

The last submitted patch, 4: 3006270-4.patch, failed testing. View results

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt1.43 KB
new 3006270-9.patch4.51 KB
gabesullice’s picture

gabesullice
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

gabesullice’s picture

gabesullice
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Done. Thanks!

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented

+1

Thanks for the work and the review!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.