when you use issuu with https request they show this message
"You are missing some Flash content that should appear here! Perhaps your browser cannot display it, or maybe it did not initialize correctly."

CommentFileSizeAuthor
#12 issuu-fix_https_request-2330551-12.patch1008 bytesabu-zakham
#6 issuu-fix_https_request-2330551-6.patch970 bytesabu-zakham
#2 issuu-fix_https_request-2330551-0.patch990 bytesabu-zakham
issuu-fix_https_request-714390-1.patch990 bytesabu-zakham
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

abu-zakham’s picture

abu-zakham CreditAttribution: abu-zakham commented
Status: Active » Needs review
abu-zakham’s picture

abu-zakham CreditAttribution: abu-zakham commented
FileSize
issuu-fix_https_request-2330551-0.patch990 bytes
abu-zakham’s picture

abu-zakham CreditAttribution: abu-zakham commented
Issue summary: View changes
mallezie’s picture

mallezie
Primary language Dutch
Location Loenhout
CreditAttribution: mallezie commented
Status: Needs review » Fixed

Thanks, this seems al nice fix.
I committed it to 6.x-dev, and added snapshot releases for the 6.x branch.
(Hope did everything right with the attribution, and issue number)

abu-zakham’s picture

abu-zakham CreditAttribution: abu-zakham commented
FileSize
issuu-fix_https_request-2330551-6.patch970 bytes

when i review the patch on live enviroment they give me this error "Could not display the flash because //static.issuu.com/webembed/viewers/style1/v1/IssuuViewer.swf does not appear to exist." and this patch fix it.

mallezie’s picture

mallezie
Primary language Dutch
Location Loenhout
CreditAttribution: mallezie commented

It could be related to swf tools, which version of swftools do you use?
Could be related to https://www.drupal.org/node/219309

abu-zakham’s picture

abu-zakham CreditAttribution: abu-zakham commented

Yeah maybe related with https://www.drupal.org/node/219309 and swftool version = "6.x-2.5" , but i testing it on chrom and firefox and give me the messsage.

mallezie’s picture

mallezie
Primary language Dutch
Location Loenhout
CreditAttribution: mallezie commented
Status: Fixed » Active

I reverted the first patch for now. I need to investigate the issue further in combination with swf tools.
The first patch (if everything works) with the protocol-agnostic urls the // would be the right solution to make it work in http / https and mixed environments.

  • mallezie committed 3d25e9d on 6.x-1.x 
    Revert "Issue #2330551 by Abdulla Abu-Zakham: Fixed issuu embed doesn't...
abu-zakham’s picture

abu-zakham CreditAttribution: abu-zakham commented

Ok mallezie , Thanks for you , patch in comment #6 work fine with me on http and https .

abu-zakham’s picture

abu-zakham CreditAttribution: abu-zakham commented
FileSize
issuu-fix_https_request-2330551-12.patch1008 bytes

i had problem with pdf file upload, same error in this issue https://www.drupal.org/node/869438
this patch works fine with me (upload and view) pdf

abu-zakham’s picture

abu-zakham CreditAttribution: abu-zakham commented
Status: Active » Needs review
dimasum’s picture

dimasum CreditAttribution: dimasum commented

issuu-fix_https_request-2330551-12.patch Works for me perfectly!

mallezie’s picture

mallezie
Primary language Dutch
Location Loenhout
CreditAttribution: mallezie commented

The patch does indeed work for https, i'm not sure it's the right way to also use it in a http-environment.
If you could test this, and confirm it works, i could commit it. But i'm not really using the D6-version myself.

mallezie’s picture

mallezie
Primary language Dutch
Location Loenhout
CreditAttribution: mallezie commented
Status: Needs review » Fixed

Abdulla Abu-Zakham confirmed to me this patch does work as expected, so i commited it. Thanks!
It will be in the dev-package tomorrow.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.