Next to ignore (blacklist) items, we should also have an option to allow (whitelist) items.

Attached patch does just that. It fixes potential problems by checking if allow/ignore is set. If not set, it sets allow to everything and/or ignore to nothing.

The check to add the text of the item is changed now to: "It should be allowed AND it should not be ignored."

Best option is to use either allow or ignore. If one uses both at the same time they have to be very, very careful.

CommentFileSizeAuthor
allow.patch949 bytesKiphaas7
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Kiphaas7’s picture

Kiphaas7 CreditAttribution: Kiphaas7 commented
Status: Active » Fixed

Committed.

http://drupalcode.org/project/instantfilter.git/commit/b66ac65
http://drupalcode.org/project/instantfilter.git/commit/dce2425

Kiphaas7’s picture

Kiphaas7 CreditAttribution: Kiphaas7 commented

Ok, wow. The commited patches were completely flawed.

Fixed partially in:
http://drupalcode.org/project/instantfilter.git/commit/9625818

Additional fix in:
http://drupalcode.org/project/instantfilter.git/commit/9622c94

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.