Problem/Motivation

Add buttons for CKEditor5

CommentFileSizeAuthor
#7 3293130-upgrade-path-7.patch6.98 KBWim Leers
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sleitner created an issue. See original summary.

cegri’s picture

Is this feature planned / scheduled?

urix’s picture

I'd love to see the integration too.
IMCE is a great tool for image management.

Wim Leers’s picture

As https://www.drupal.org/project/usage/imce shows, IMCE usage is dwindling significantly. People are migrating to Drupal core's Media Library. 80% of the user base (all versions of the IMCE module except 8.x-2.x) is on legacy Drupal versions: 6, 7 and 8. Only 20% (60K sites today) are on Drupal 9.

This shows that the Drupal ecosystem is moving on to Media Library.

With the https://www.drupal.org/project/media_migration module, doing that is easy (for D7 → D9).

I think our time would be far better spent getting the entire Drupal ecosystem on Media Library rather than working on CKEditor 5 support for IMCE.

Wim Leers’s picture

Title: CKEditor5 integration » CKEditor 5 integration
Priority: Normal » Critical

This will be critical once Drupal 10 is out, which is … soon.

ufku’s picture

Version: 8.x-2.x-dev » 3.0.0
Status: Active » Fixed

Released 3.0.0 which is compatible with Drupal 10 and has ckeditor5 integration.

Wim Leers’s picture

Status: Fixed » Needs review
FileSize
6.98 KB

Awesome work in https://git.drupalcode.org/project/imce/-/commit/f7dcab09281eb6e30095179...! 👏

I do see in https://git.drupalcode.org/project/imce/-/tree/3.x/src/Plugin that the CKEditor 4 and 5 plugins are both present in the same version — that's great! That enables sites to easily transition.

What would make things even better though, is if there was an automated update path. For that, you'd need to add a CKEditor4To5Upgrade plugin, which would be really simple in this case

  1. ImceImage (CKE4) → imce_image (CKE5)
  2. ImceLink (CKE4) → imce_link (CKE5)

Ideally you'd also add test coverage to prove that the upgrade path works.

Patch attached that does all of that.

  • ufku committed 7bb2281 on 3.x
    Issue #3293130 by Wim Leers: Added CKEditor4To5Upgrade plugin
    
ufku’s picture

Version: 3.0.0 » 3.x-dev
Status: Needs review » Fixed

Committed, thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.