Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
With the latest version of jQuery allowed by jquery_update module (1.10), the version of jcrop in this module throws 'Uncaught type' error on $.browser.msie check, because $browser was removed from jQuery in v.1.9. Updating jcrop to the latest version, v0.9.12 resolves the issue for me.
Suggestions:
- Make jquery_update a dependency for the module?
- Take jcrop out of the module altogether and require users to install it on their own, e.g. in sites/all/libraries?
Comment | File | Size | Author |
---|---|---|---|
#3 | imagefield_crop-2694499-1.patch | 111.05 KB | prat |
Comments
Comment #2
ram4nd CreditAttribution: ram4nd as a volunteer commentedComment #3
prat CreditAttribution: prat commentedI would like to propose a patch against 7.x-1.1 (which seems to be the only completely working solution) except JCrop issue
Comment #4
CatherineOmega CreditAttribution: CatherineOmega commentedSeconding this. Updating it worked for me.
Comment #5
ram4nd CreditAttribution: ram4nd as a volunteer commentedNeeds to be refactored against dev branch. Since there is no "7.x-1.1" branch, it's a tag. If there are any issues they should be patched.
Comment #6
ram4nd CreditAttribution: ram4nd as a volunteer commentedComment #7
PimD1988 CreditAttribution: PimD1988 commentedAnother small fix is recommended:
In imagefield_crop.module there is still a reference to the old jquery.Jcrop.js file which is deleted on applying this patch.
It should be changed to
see line 201.
Hope this helps!