crop wasn’t implemented so here it is

thanks,
introfini

CommentFileSizeAuthor
imagecache.module.patch773 bytesintrofini

Comments

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Active » Needs review
lenart’s picture

lenart commented

This obviously doesn't work for me (Drupal 4.7.3 & Imagecache from CSV). I'm not sure what this patch does is OK. It even breaks the settings page - I'm guessing due to incorrect case sentence.

        case 'crop':
           if (!image_crop($tmpdestination, $tmpdestination,................)
           break;
        case 'crop':
          $form[$actionid]['data']['width'] = array(
            '#type' => 'textfield',

I think it should be more like

        case 'crop':
           if (!image_crop($tmpdestination, $tmpdestination,................)

          $form[$actionid]['data']['width'] = array(
            '#type' => 'textfield',
zach harkey’s picture

zach harkey commented

Does that work?

dopry’s picture

dopry commented
Status: Needs review » Closed (fixed)

committed to HEAD with modification.

zach harkey’s picture

zach harkey commented

I still can't get images to crop no matter what I do. Does this work for anyone else?