When creating or editing a preset, the action names and descriptions in the "New Actions" area are never passed through the t() function, which means they are not translatable/translated. The accompanying patch adds the t()-function upon building the new actions block (which means that other modules which may provide their own imagecache actions do not have to be changed).

Only snag might be that other modules may already be passing their names and descriptions through t(), which would result in t being called twice.

Comments

eelkeblok’s picture

Status: Active » Needs review
drewish’s picture

Status: Needs review » Needs work

I don't think we shouldn't be calling t() there. It should called where they're defined in imagecache_imagecache_actions().

eelkeblok’s picture

Assigned: Unassigned » eelkeblok

Fair enough. I do believe the automatic string scraping for localize.drupal.org will not work the way I implemented the patch, but I thought this was the least intrusive. I'll change the patch as soon as I can.

eelkeblok’s picture

Status: Needs work » Needs review
StatusFileSize
new3.25 KB

Here is a patch that instead calls t() in imagecache_imagecache_actions()

fizk’s picture

Status: Needs review » Closed (fixed)
Issue tags: +ImageCache 2.x Todo

Marking as ImageCache 2.x Todo.