disappearing image

Can you tell if this issue goes away if the htmLawed module is disabled?

Don't mean to hijack this issue, but I was just about to report an issue where an image wouldn't show on the frontpage. Maybe they're the same. Here's the situation:

I have a custom block (ie created via Blocks -> Add block) with text and an image. The image would show up on every page except the front page. I traced the code through and think I know what's going on: on the front page it was using the Other settings. On the other pages it saw that is_numeric(arg(1)) is true, and assumed (wrongly) that the text was body text.

It seems to me (in my very humble opinion!) that it's not very Drupal to have all the same inputs (ie text, input format, block, region) and different filtered text output depending on the path! And doesn't that make it uncacheable? (And maybe that explains why the OP's problem's intermittent?) Or have I missed something?

(And again, I hope I haven't hijacked this issue with something unconnected!)

TIA

Andy

Andy,

Thanks for informing about your issue and identifying what causes it.

A Drupal node has a 'body' and a 'teaser,' and I wanted to have the htmLawed module provide options to filter them in different ways (so, for instance, images are not shown in 'teaser'). I had to think of 'other' for the case when the htmLawed module is unable to identify if the text being filtered is for 'body' or 'teaser.' Clearly, as seen from your post and this one, the module's code is not very good at identifying 'body' from 'other' (by looking at the path); may be it is impossible to do so.

I have thought of just having one special case, that for 'teaser', with everything else filtered as per 'body', but I am not sure how it will affect current users since some may have been relying on an 'other' vs 'body' distinction.

I will appreciate any suggestion.

I'm afraid I don't have any good ideas for a way forwards for current users (except maybe starting a version 3.x and recommending using htmLawed with better formats).

What I personally think would be a better way (and more in line with the other filters I'm familiar with) would be this:

1. The filter's configuration screen should allow you to set Help, Config. and Spec. once for that input format.
2. If you want to have different configs for htmLawed in different situations, then you need to make different input formats.
3. If someone wants different formats for node bodies, comments, blocks they can use a contrib module (I use better formats). This also allows you to choose input formats per content type.
4. Views already allows you to choose your input format for headers and footers.

I don't know of a module that lets you choose a different input format for full node vs teaser, but such functionality imho should not live in a filter, but in a separate contrib module.

I honestly think that having only one set of settings to enter on the config screen would make the module easier to use, and would tie in better with other input format related modules, and other filters.

HTH

audio.zoom,

Thanks for the feedback. I wonder if the issue would have been resolved if the latest version of the htmLawed module was used. This release addresses caching issues.

Anyway, I am closing this issue.

@alpha2zee For me at least, this issue is a deal-breaker. Would you accept a patch that modified behaviour as described in #5? (If not please just re-close the issue, thanks.)

AndyF,

Sorry if I closed the issue prematurely. I was planning on separately addressing the issue you raised.

I can accept a patch... and will be thankful.

Santosh

Yeah, actually that's a much better idea!