When I upgrade to 2.1, I see this message: "You need to manually upgrade the custom 'before' code snippet."

What does that mean? There is nothing in the release notes or README that explains this.

Comments

arnoldbird created an issue. See original summary.

hass’s picture

Component: User Interface » Documentation
Category: Bug report » Support request
Status: Active » Fixed

You have used an advanced js code snippet. See google analytics api migration site - how to migrate your old code snippet to the new syntax, please.

If you need help I can offer you paid consulting/developer service. Feel free to contact me directly.

arnoldbird’s picture

Thanks. I found the snippet in the advanced settings and I see it does not work with Google's latest API.

Google refers to its old API as ga.js and the new API as analytics.js, if you want to reference these specifically in the module description or the README and indicate that the 2.1 version of the module requires using the newer analytics.js API.

hass’s picture

Isn't that not already written on project home and in several places of the user interface?

arnoldbird’s picture

I'm not seeing any note to that effect on the project homepage nor in any other location. Apologies in advance if I'm missing something.

What I'm suggesting here is that because the upgrade from 1.x to 2.x depends on the use of a different Google API, this should be noted in some or all of the following places: project page, release notes, README. Again, apologies in advance if in fact this is noted somewhere, and I'm just missing it. Thanks.

hass’s picture

Version: 7.x-2.1 » 7.x-2.x-dev
Component: Documentation » Code
Category: Support request » Task
Status: Fixed » Active

Update hook can be more verbose in the messages.

  • hass committed 1131b3b on 7.x-2.x
    Issue #2581767 by hass: Mention the Google API in update messages
    
hass’s picture

Status: Active » Fixed

  • hass committed 36f681f on 7.x-2.x
    Issue #2581767 by hass: Mention the Google API in update messages
    

  • hass committed 33d45b6 on 7.x-2.x
    Issue #2581767 by hass: Mention the Google API in update messages
    

  • hass committed 9a9d4e0 on 6.x-4.x
    Issue #2581767 by hass: Mention the Google API in update messages
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.