CommentFileSizeAuthor
#16 this_t_should_be-2844565-16.patch34.77 KBdhruveshdtripathi
#14 interdiff_12-14.txt985 bytesdhruveshdtripathi
#14 this_t_should_be-2844565-14.patch35.59 KBdhruveshdtripathi
#12 this_t_should_be-2844565.patch35.35 KByukare
#10 this_t_should_be-2844565-10.patch36.38 KBdhruveshdtripathi
#5 interdiff_2-5.txt28.83 KBdhruveshdtripathi
#5 this_t_should_be-2844565-5.patch57 KBdhruveshdtripathi
#2 geshifilter_2844565_1.patch31.79 KBnehakhadke
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nehakhadke created an issue. See original summary.

nehakhadke’s picture

nehakhadke CreditAttribution: nehakhadke at Invezza Technologies commented
FileSize
geshifilter_2844565_1.patch31.79 KB
yukare’s picture

yukare CreditAttribution: yukare commented
Status: Needs work » Needs review

Sorry for not working on this before. Changed to need review so the test bot works, i read the patch and it is good, if it pass on test bot i will commit it.

Status: Needs review » Needs work

The last submitted patch, 2: geshifilter_2844565_1.patch, failed testing.

dhruveshdtripathi’s picture

dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda for OpenSense Labs commented
Status: Needs work » Needs review
FileSize
this_t_should_be-2844565-5.patch57 KB
interdiff_2-5.txt28.83 KB

Few remaining t() functions replaced with $this->t(). Tried to solve test fails. Interdiff attached.

Status: Needs review » Needs work

The last submitted patch, 5: this_t_should_be-2844565-5.patch, failed testing.

yukare’s picture

yukare CreditAttribution: yukare commented
Status: Needs work » Needs review

We had a fatal error because a change in geshi before, it is fixed now, lets see if it pass the test now, and this error is strange because it is not related to patch.

Status: Needs review » Needs work

The last submitted patch, 5: this_t_should_be-2844565-5.patch, failed testing.

dhruveshdtripathi’s picture

dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda for OpenSense Labs commented
Assigned: Unassigned » dhruveshdtripathi

Understood the problem, working on it.

dhruveshdtripathi’s picture

dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda for OpenSense Labs commented
Assigned: dhruveshdtripathi » Unassigned
Status: Needs work » Needs review
FileSize
this_t_should_be-2844565-10.patch36.38 KB

Updated patch

Status: Needs review » Needs work

The last submitted patch, 10: this_t_should_be-2844565-10.patch, failed testing.

yukare’s picture

yukare CreditAttribution: yukare commented
FileSize
this_t_should_be-2844565.patch35.35 KB

Fixed two errors(using $this in static functions), now it pass on my pc, lets see if it pass now on testbot.

yukare’s picture

yukare CreditAttribution: yukare commented
Status: Needs work » Needs review

Change to need review for the bot.

dhruveshdtripathi’s picture

dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda for OpenSense Labs commented
FileSize
this_t_should_be-2844565-14.patch35.59 KB
interdiff_12-14.txt985 bytes

Replacement was left at one place and also corrected the mistake where $t() was there instead of t() or $this->t(). Interdiff added.

Status: Needs review » Needs work

The last submitted patch, 14: this_t_should_be-2844565-14.patch, failed testing.

dhruveshdtripathi’s picture

dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda for OpenSense Labs commented
Status: Needs work » Needs review
FileSize
this_t_should_be-2844565-16.patch34.77 KB
dhruveshdtripathi’s picture

dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda for OpenSense Labs commented

drupal_set_message($t('Could not generate external CSS file. Check the settings of your <a href="!filesystem">file system</a>.',

Replaced $t() with t() only.

yukare’s picture

yukare CreditAttribution: yukare commented
Status: Needs review » Fixed

Commited, thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.