I just enabled the GAC module to use it with existing galleries. I configured the module settings and saved them, then went to the gallery. Below the image I saw the headline "Comments", but no comment form, link or anything.

After a lot of debugging, I traced this to gallery_assist_comments.module, line 551. Here, the type_settings are copied to the node_settings, if there are no node_settings already (there aren't for my galleries) and if $type_settings['general']['user_settings'] is 1 or 2. In my case, it wasn't 1 or 2, because I don't want the users to overwrite the default settings for individual galleries. Because of this, gallery_assist_comments_list is called with only the three settings set in line 558-562. There's no position setting in $node_light->node_settings, and that's why no form is displayed.

I think, the check in line 551 is wrong. I'm not quite sure what this is supposed to achieve, but if a node has no settings, the type settings need to be used always. If the type settings should not be saved at the node (are they?), then the code needs to differentiate which settings to use.

I just checked this with the dev version and it's almost the same except that now even the "comments" headline is gone. The workaround for now is to set the setting Site configuration > Gallery Assistent > Assignments > GAC > General Settings > Allow user settings to something else than "No".

Comments

bushrang3r’s picture

.....sorry, made a mistake...can't see how to delete this...