Add composes.libraries.json to flexslider project [#3185456]

Problem/Motivation

Using Composer for installation is more and more becoming the standard. Yet, the libraries are still be uploaded the manual way using i.e. filezilla

Proposed resolution

create a composer.libraries.json file so the libraries can be uploaded using the wikimedia composer-merge-plugin

Remaining tasks

User interface changes

API changes

Data model changes

Comment	File	Size	Author
#9	3185456-6.patch	1.28 KB	bart lambert
#9	8.x-2.x: PHP 7.1 & MySQL 5.5, D8.9 Patch Failed to Apply
#5	3185456-5.patch	1.54 KB	Pooja Ganjage
#5	8.x-2.x: PHP 7.1 & MySQL 5.5, D8.9 4 pass PHP 7.4 & MySQL 5.7, D8.9 4 pass
#4	Schermafbeelding 2020-12-02 190449.png	13.46 KB	bart lambert
#2	3185456-2.patch	1.53 KB	Pooja Ganjage
#2	8.x-2.x: PHP 7.1 & MySQL 5.5, D8.9 4 pass

Issue fork flexslider-3185456

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3185456-composes.libraries.json changes, plain diff MR !1 / changes, plain diff MR !11
Check out this branch

About issue forks

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

29 November 2020 at 22:57

bart lambert created an issue. See original summary.

Comment #2

Pooja Ganjage CreditAttribution: Pooja Ganjage at Asentech LLC commented 1 December 2020 at 11:33

File	Size
3185456-2.patch	1.53 KB
8.x-2.x: PHP 7.1 & MySQL 5.5, D8.9 4 pass

Hi,

Creating a patch for this issue.

Please review the patch.

Let me know if any suggestions.

Thanks.

Comment #3

Pooja Ganjage CreditAttribution: Pooja Ganjage at Asentech LLC commented 1 December 2020 at 11:34

Status:

Active

» Needs review

Comment #4

bart lambert CreditAttribution: bart lambert commented 2 December 2020 at 18:07

File	Size
Schermafbeelding 2020-12-02 190449.png	13.46 KB

tested but got an error that download failed:

File	Size
3185456-5.patch	1.54 KB
8.x-2.x: PHP 7.1 & MySQL 5.5, D8.9 4 pass PHP 7.4 & MySQL 5.7, D8.9 4 pass

Comment #6

bart lambert CreditAttribution: bart lambert commented 2 December 2020 at 22:17

tested and working on php 7.4 & MySQL 5.7 D8.9.10

Comment #7

bart lambert CreditAttribution: bart lambert commented 3 December 2020 at 10:33

Composer is actually being update to version 2.0 which poses problems with the wikimedia/composer-merge-plugin:^1.4.1.

Persons using composer 2.0 have to use:

wikimedia/composer-merge-plugin:"dev-feature/composer-v2 as 1.5.0"

So in the composer.libraries.json file line 20:

"wikimedia/composer-merge-plugin": "^1.4.1" should be replaced by

"wikimedia/composer-merge-plugin": "dev-feature/composer-v2 as 1.5.0"

I don't know if this newer version is backwards compatible with the composer version 1

Comment #8

bart lambert CreditAttribution: bart lambert commented 3 December 2020 at 10:43

ANother Hickup!

Using composer-merge-plugin and the proposed composer.libraries.json file, the library is installed in the libraries-folder in the folder woocommerce.flexslider and actually it needs the foldername flexslider