Flag bookmark view is broken

Postponing until #2448881: Adding relationship to user views does not work is fixed.

Stashing some work here to update the view while working on another issue.

This issue is fixed, so we can work on it again.
And this patch was empty.

I think that the problem here is that in FlagViewsFilter doesn't have set the relationship, so the ensureMyTable set tableAlias to NULL, that's why is doing "(.uid IS NOT NULL)"

Requiring this relationship we don't need the filter anymore, so set to required and deleted the filter from the view.
This is the result:

Also fixed the buildOptionsForm and added the schema for the filter, I'm not sure if I have to fix it or we should drop the filter directly.

I think we can add tests here with check config schema disabled an enable it in this issue #2555365: Add views schema for flag_relationship.

+++ b/flag_bookmark/src/Tests/FlagBookmarkUITest.php
@@ -0,0 +1,78 @@
+
+    $this->drupalCreateContentType(['type' => 'article', 'name' => 'Article']);
+

Interesting, the bookmark flag has configuration enabled for article and page node types, but we can enable it when those don't exist. We're either missing calculateDependencies() implementations on those plugins or haven't updated the default config there. Not a problem if this issue, but it's going to bite us at some point when we implement that properly, then a) tests like this won't work anymore and b) the module won't be installable on non-standard based install profiles.

+++ b/flag_bookmark/src/Tests/FlagBookmarkUITest.php
@@ -0,0 +1,78 @@
+
+  public static $modules = array(
+    'views',
+    'flag',
+    'flag_bookmark',
+  );
+
+  protected $strictConfigSchema = FALSE;

missing docblocks.

I think we should either leave out the config scheme here completely or we should just include the remaining part of the config schema fix from the other issue in either. The current state of adding a bit of config schema but not actually testing it seems a bit weird.

> We're either missing calculateDependencies() implementations on those plugins

Very likely!

Ok in case, I'll upload the two patches, this is with the schema errors fixed from this issue #2555365: Add views schema for flag_relationship.
Adding the bookmark view has apeared new schema errors that I had to fix.

Here the second patch without schema fix.

I am limiting this review to just the new test ( FlagBookmarkUITest )

Yep, looks clean -- it will prevent recurrences of the problem - so +1 from me!

Also phpcs reports no cs snafu's

Confirming that flag_bookmark_view_is-2562971-10.patch works for me. I now get the Flag Bookmark List view after enabling flag_bookmark.

I think this is ready.

It's up to @joachim to decide which patch to commit. #9 includes the schema fixes from that other issue already and we could just close this or #10, which is with config schema checking disabled, then we need to reroll the other issue and just remove the disabled flag in the test.

Since this has sat for over month, I decided to take the smaller patch. We will need to split off the related fixes into a separate issue.

Remaining fixes for reference.