There's a call to $this->get_flagging() when building the parameters for invoking the Rules event. But there's a $flagging object right there!

CommentFileSizeAuthor
#2 2250543.flag_.rules-get-flagging.patch525 bytesjoachim

Comments

joachim’s picture

joachim commented

Sanity check: by the time we get to the Rules invocation:

- the $flagging has been passed to drupal_write_record(), so it has an entity ID
- the $flagging has been passed to field_attach_insert(), so logically it has all the field data on it already

Therefore, the $flagging we have is as good as it's going to get. We won't gain anything by doing an entity_load() with it.

joachim’s picture

joachim commented
Status: Active » Needs review
StatusFileSize
new 2250543.flag_.rules-get-flagging.patch525 bytes

  • Commit 0f65951 on 7.x-3.x by joachim: 
    Issue #2250543 by joachim: Removed pointless call to get_flagging().
joachim’s picture

joachim commented
Status: Needs review » Fixed

Tests pass, and I'm happy with my sanity check :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.