The import menu item is not consistent with views module (the grandfather of exportables)..
the menu type should be MENU_LOCAL_ACTION

CommentFileSizeAuthor
#7 flag-1371644-7.patch722 bytescs_shadow
#5 flag-1371644-5.patch436 bytescs_shadow

Comments

joachim’s picture

Status: Active » Postponed (maintainer needs more info)

It shows as a tab on 7.x-3.x. Also Views 3 is rather different as it uses dropdown menus.

Scyther’s picture

It sounds good to have the Import link next to the Add link as an action link instead of a tab.

Talking about 7.x-3.x version, and also maybe in the other version to.

joachim’s picture

I forget which one is MENU_LOCAL_ACTION and which is LOCAL_TASK as they are pretty much DX WTF misnomers.

Basically -- if you want to change the status quo, reopen and file a patch ;)

joachim’s picture

Version: 7.x-2.x-dev » 7.x-3.x-dev
Issue summary: View changes
Status: Postponed (maintainer needs more info) » Active
Issue tags: +Novice

It looks like all the CTools exportables have the 'Import' as a local task rather than a tab.

Shouldn't be too tricky to make a match; tagging as novice.

cs_shadow’s picture

Status: Active » Needs review
StatusFileSize
new436 bytes

Changed Import menu item to MENU_LOCAL_ACTION in accordance with Views. Do you think we also need to change the export menu item?

joachim’s picture

Status: Needs review » Needs work

> Do you think we also need to change the export menu item?

Now there's a dilemma!

The docs at https://api.drupal.org/api/drupal/includes!menu.inc/constant/MENU_LOCAL_... suggest we should.

It also looks really odd to have import and export in different parts of the UI.

So yes, let's do that in this patch too.

cs_shadow’s picture

Status: Needs work » Needs review
StatusFileSize
new722 bytes

Changed the export menu item also to MENU_LOCAL_ACTION.

joachim’s picture

Status: Needs review » Fixed

Thanks!

  • Commit 7692cc1 on 7.x-3.x authored by cs_shadow, committed by joachim:
    Issue #1371644 by cs_shadow: Fixed import and export menu items to be...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.