Problem/Motivation

Like for other cache backends in core and contrib, the serializer should be configurable instead of hardcoding the usage of the php serializer.
That would allow to use igbinary and/or a compressing serializer which make a lot of sense for files.

Steps to reproduce

Proposed resolution

Follow the examples in core and contrib and use dependency injection for the serializer service

Remaining tasks

User interface changes

none

API changes

Additional constructor argument which isn't a BC break in Drupal.

Data model changes

none

CommentFileSizeAuthor
#6 interdiff.txt3.46 KBpfrenssen
#6 3330728-6.patch6.11 KBpfrenssen
#2 3330728.patch5.15 KBmkalkbrenner

Comments

mkalkbrenner created an issue. See original summary.

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Status: Active » Needs review
StatusFileSize
new 3330728.patch5.15 KB
socialnicheguru’s picture

socialnicheguru commented
Related issues: +#3330477: Make igbinary usable without needing module enabled., +#2836091: Swap serialization in DatabaseBackendFactory
socialnicheguru’s picture

socialnicheguru commented

from #3357130: PHP 8.1 serializer vs igbinary serializer speed and memory usage

We run PHP 8.1. We switched a file based cache from serialize to igbinary and the file size was reduced by aprox. 90%. So this was a massive improvement.

socialnicheguru’s picture

socialnicheguru commented
Status: Needs review » Reviewed & tested by the community

This works well.
I am able to replace serializer.

pfrenssen’s picture

pfrenssen
Location Sofia
commented
StatusFileSize
new 3330728-6.patch6.11 KB
new interdiff.txt3.46 KB

This is a really good idea. I tried out the serialization.igbinary_gz service from the igbinary module and it reduced my cache folder to 25.18% of the original size.

However this took some figuring our since the igbinary module is still experimental and doesn't have much documentation. It's README consists mostly of TODOs.

Patch adds instructions on how to set it up, and does some small documentation updates.

pfrenssen’s picture

pfrenssen
Location Sofia
commented
Status: Reviewed & tested by the community » Fixed

Thanks!

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented

:-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.