Deprecated function: trim(): Passing null to parameter #1 ($string) of type string is deprecated in Drupal\feeds\Feeds\Target\Link->prepareValue() (line 32 of feeds/src/Target/Link.php)

Output of git diff -w (easier to read):

$ git diff --cached -w
diff --git a/src/Feeds/Target/Link.php b/src/Feeds/Target/Link.php
index f8bd3040..878f392b 100644
--- a/src/Feeds/Target/Link.php
+++ b/src/Feeds/Target/Link.php
@@ -29,6 +29,7 @@ class Link extends FieldTargetBase {
    * {@inheritdoc}
    */
   protected function prepareValue($delta, array &$values) {
+    if (!empty($values['uri'])) {
       $values['uri'] = trim($values['uri']);
 
       // Support linking to nothing.
@@ -36,7 +37,7 @@ class Link extends FieldTargetBase {
         $values['uri'] = 'route:' . $values['uri'];
       }
       // Detect a schemeless string, map to 'internal:' URI.
-    elseif (!empty($values['uri']) && parse_url($values['uri'], PHP_URL_SCHEME) === NULL) {
+      elseif (parse_url($values['uri'], PHP_URL_SCHEME) === NULL) {
         // @todo '<front>' is valid input for BC reasons, may be removed by
         //   https://www.drupal.org/node/2421941
         // - '<front>' -> '/'
@@ -50,5 +51,6 @@ class Link extends FieldTargetBase {
         }
       }
     }
+  }
 
 }

I can roll a patch with an early return if this is preferred. I.e.:

if (empty($values['uri'])) {
  return;
}

#3306211: Deprecated function: trim(): Passing null is deprecated as of PHP 8 is indeed similar but it handles DateTargetBase. This issue is in Link target.

Do you like to merge those two issues?

Does the link field get emptied when the passed value is null?

What is supposed to happen if after prepareValue $values['uri'] is NULL?. Is that handled differently than if $values['uri'] is an empty string?

If the output should be the empty string if null is passed in, then we could fix it the same way as in #3306211: Deprecated function: trim(): Passing null is deprecated as of PHP 8, namely ($values['uri'] = trim((string) $values['uri']).

This patch implements idea from #3306211: Deprecated function: trim(): Passing null is deprecated as of PHP 8. No interdiff.txt, since this is a different approach than comment 2.