Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
My web site has multiple feeds importers that I monitor using the Feeds Log view.
Because of the number of feeds importers running, the frequency they are run, and the number of events logged, I needed a new exposed filter which makes it possible to filter by Importer ID.
I have added an exposed filter for this purpose, exported the updated feeds log view to code, and created a patch to share this feature.
If you are interested, please take a moment to review this patch and to share your comments or feedback.
Thank you,
Gordon
Comment | File | Size | Author |
---|---|---|---|
#13 | feeds-importer-id-exposed-filter-2849636-4.patch | 7.62 KB | gturnbull |
#9 | feeds-importer-id-exposed-filter-2849636-3.patch | 7.56 KB | gturnbull |
#8 | 2849636-feeds-log.png | 89.04 KB | MegaChriz |
#6 | feeds-importer-id-exposed-filter-2849636-2.patch | 7.23 KB | gturnbull |
| |||
#3 | feeds-importer-id-exposed-filter-2849636.patch | 7.55 KB | gturnbull |
|
Comments
Comment #2
gturnbull CreditAttribution: gturnbull commentedComment #3
gturnbull CreditAttribution: gturnbull commentedComment #4
gturnbull CreditAttribution: gturnbull commentedComment #5
MegaChriz CreditAttribution: MegaChriz as a volunteer commented@gturnbull
It seems that your patch contains some environment specific configuration:
It would be better if you export your view from within a clean install.
Still have to test the patch, though. I had only a few minutes for Feeds now.
Comment #6
gturnbull CreditAttribution: gturnbull as a volunteer commentedHi MegaChriz,
I removed the environment specific configuration settings, re-exported my view, and created a new patch.
Thank you for taking the time to review this new feature.
Thank you,
Gordon
Comment #7
gturnbull CreditAttribution: gturnbull as a volunteer commentedComment #8
MegaChriz CreditAttribution: MegaChriz as a volunteer commentedI get the following error message on the feeds log page after applying the patch:
See also the image:
I checked if I could fix the error by editing the view, but then I could only add a text field as exposed filter for the importer. A field where you can select the importer would indeed be nicer. I think that you have an extra module installed so that the exposed filter became a select field? Anyway, to fix this for everyone we probably need a Views filter plugin specific for the importer ID.
Comment #9
gturnbull CreditAttribution: gturnbull as a volunteer commentedHi MegaChriz,
I figured out the problem! The exposed filter I added for the Importer ID field uses a select box feature provided by the views_selective_filters module.
I updated the feeds.info file to include a dependency for the views_selective_filters module, then generated an updated version of my patch.
If you have a moment, please test my latest patch and let me know what you think.
Your feedback is greatly appreciated.
Thanks,
Gordon
Comment #10
gturnbull CreditAttribution: gturnbull as a volunteer commentedComment #12
MegaChriz CreditAttribution: MegaChriz at WebCoo commentedHm, adding an extra dependency for Feeds for such a small feature doesn't look like a good idea to me. People will complain that they would need to install an extra module for a feature that they don't use. See for example #1355994: Remove Job Scheduler dependency.
The way to fix this with the least impact is to write a specific Views filter handler for the Importer ID field.
Comment #13
gturnbull CreditAttribution: gturnbull as a volunteer commentedHi MegaChriz,
Thanks again for your feedback. I will create a separate views handler to power the select box filter implemented for the Importer ID field.
In the meantime, I noticed an error in my last patch. The machine name of the module referenced by the dependency was not correct. Updated patch attached.
Thank you,
Gordon