FeaturesConfigInstaller missing ConfigInstaller $install_profile argument on core 8.3.x

install_profile change breaks things in lots of places. For example - ran the features test suite and saw some errors

Drupal\Tests\features\Unit\FeaturesManagerTest::testPrepareFiles
Drupal\Core\DependencyInjection\ContainerNotInitializedException: \Drupal::$container is not initialized yet. \Drupal::setContainer() must be called with a real container.
Drupal\Tests\features\Unit\FeaturesManagerTest::testImport
Drupal\Core\DependencyInjection\ContainerNotInitializedException: \Drupal::$container is not initialized yet. \Drupal::setContainer() must be called with a real container.
Drupal\Tests\features\Unit\FeaturesManagerTest::testGetExportInfoWithBundle
Drupal\Core\DependencyInjection\ContainerNotInitializedException: \Drupal::$container is not initialized yet. \Drupal::setContainer() must be called with a real container.

That's how it should be, IMO.

Also this is blocker for https://www.drupal.org/pift-ci-job/596698

An issue created for 8.x-3.x-dev. Let's have problem resolved for this branch and then will do a backport.

Stop, I was wrong. Ignore me. You meant that Features 8.3 should be compatible with core 8.2 as well. Now I've got it.

@fgm, then your fix is better!

This should fix the tests.

Added some explanations as comments to code.

Thanks all, this looks good, I'll wait for the tests to run and then apply it.

@nedjo, do you have an idea why tests fails on PHP 5.6?

@nedjo, do you have an idea why tests fails on PHP 5.6?

No. I actually can't make out what the test results mean.

Still, I'm tempted to apply this as is as at least a step in the right direction.

@mpotter: what do you think?

OK, I think this patch is a good step forward. The testbot is complicated and hard to debug, so am going to push this and then play with the test bot a bit more.

For example, I don't know why in #13 the failing tests say D8.4

Only change I made was to the __construct() declaration. I know it's nice to wrap those long argument lists but trying not to mix formatting with actual code changes. Also, trying to stick with core style here.

Committed to ee9ff35

I'm getting the following error with Features 3.3, Drupal 8.2.6, and an install profile set.

Argument 6 passed to Drupal\Core\Config\ConfigInstaller::__construct() must implement interface Drupal\Core\Extension\ProfileHandlerInterface, string given, called in                         [error]
../modules/contrib/features/src/FeaturesConfigInstaller.php on line 64 and defined ConfigInstaller.php:87

From the code in the FeaturesConfigInstaller, it looks like the issue is with $install_profile = drupal_get_profile();. In 8.2.x this function returns a string per https://api.drupal.org/api/drupal/core%21includes%21bootstrap.inc/functi....
However, in 8.3.x this function could return a profile handler object even though the doc does not state that - https://api.drupal.org/api/drupal/core%21includes%21bootstrap.inc/functi...

Note:
This error occurs due to the subprofile patch at #1356276: Allow profiles to define a base/parent profile.

I also had $settings['install_profile'] set in my settings.php. Remove that appears to have fixed the issue since drupal_get_profile() will return NULL.
This is not ideal since then there is no "install_profile" set.

Please create a new issue for this. This is an issue with an incompatibility between the ConfigInstaller interface assumed by Features in D8.2 and D8.3 with the additional ProfileHandler argument added to ConfigInstaller by the inherited profile patch in #1356276: Allow profiles to define a base/parent profile. Since this issue is closed/fixed nobody will see it and we don't want to post an additional patch in this fixed issue.