Patch set All-in-one

This new patch from Comment #4 works very well.

Hey, while you're at it, could you make a <span class="fblogintext"></span> around the "Sign in using Facebook" text next to the login button in the fbconnect.module file? Or even remove it completely. I can't get rid of it using CSS because whatever I do to try to remove it also removes the login button.

Basically just change the Sign in using Facebook text be <span class="fblogintext">Sign in using Facebook</span>.

I've been going into the file and just deleting the text manually, but that is kinda hacky.

I would like to echo Gregarios' request in comment #5...

Check this. I believe that is more flexible way. With it you can fully configure fbconnect button through hook_form_alter or style sheets

Actually, we're having problems modifying the text next to the button, using CSS. Modifying the button itself is not a problem.

Oh yes... I applied the previous patch again by mistake. Your new patch should work. Can you combine them again into a new "all-in-one" patch? :-)

Uh oh... Problem with patch from #4: It breaks IMCE Upload functionality somehow. The window containing the upload files still seems to be intact, but the upload form is somehow hidden in it now. Attached is the source code of the IMCE Upload window for reference.

Turning off Facebook Connect restores functionality, then re-enabling it breaks IMCE again.

The attachment named "IMCE_Form_Broken.txt" shows the source code of the page that is broken.
The attachment named "IMCE_Form_Working.txt" shows the only the source code of the working page that is different from the broken page.

It's not informative. I can't reproduce the bug.

Sorry... its the best I can do right now. There are no PHP errors or any errors registered in the logs. It seems to be something getting overridden in the CSS maybe.

I downgraded to the standard Beta8 and the bug is gone.

can you give me acces to page where error occurs?

Not really... However... I've narrowed it down a lot. The attached image illustrates my plight. The window on the upper left is what the file browser should> look like. The window on the right is what I get. The small window showing your fbconnect.js file is the key. IF the red text portion of it is removed, the browser works correctly as in the upper-left window. If it is left in, the right window is what happens. It seems all image previews are removed as well now that I notice.

That's it. Your update works great. All the functionality and no problems.
How can we get this turned into a Version 1.0 release? :-)

Vectoroc will need maintainer privileges to create a 1.0 release. Are the current maintainers still maintaining the module at all?

Are the current maintainers still maintaining the module at all?

It would seem not, as the last commit was over 21 weeks ago...

Can someone step in and assume control?

+1 from me.

Just launched a new Website including fbconnect.
Would love to see the latest contributions in upstream repositor and new supported releases.

Hi vectoroc,

great work! I think about using this fork for my fork (#617778: Facebook depricates template bundles and their APIs...) - instead of the orignial module. We might coordinate our future work on this to avoid to much different forks...

Are you currently working on this?

I thought about a drupal module fork. but we will have to put the module here in one of our issues as we don't have cvs permissions for this module and - in my case - not even cvs permissions at all...

So I will use your latest fork for my developement and we bring our both forks together when we're finish??

Could this be the plan?

If you start working on Github, please make announcements of new versions in this thread if you would. :)

+1 subscribing

+1 for rolling this into a new Drupal 1.0 version...

Quick question, just to make sure...
Patch above is a few days older than latest version at github.
It seems better to get it from there.
Steps would be:
1. Download fbconnect module from Drupal Project Repository at http://www.drupal.org/project/fbconnect
2. Get Facebook Platform from http://svn.facebook.com/svnroot/platform/clients/packages/facebook-platf...
3. Get updated code from http://github.com/vectoroc/fbconnect and copy it over the sites/all/modules/fbconnect files overwriting old files and keeping unchanged ones.
4. Run update.php ?

Would that do it?

So I don't want to be maintainer of this project because for me it's temporary work

A temp maintainer is better than no maintainer in my book. I would LOVE to see you get it and update it even if it is just to get a new bug-fixed release version out. Looks like it is almost there in patches. If you decided after a week to put a note up abandoning the project again, I for one wouldn't hold it against ya. :-)

I agree with you vectoroc. I don't want to be maintainer here if the changes with the api are done...

Thats a +1 for github, is'nt it?

I'd never even heard of github before this thread. If the updated module is "kept" over there, the potential user base will be severely restricted. It just seems like a shame to not keep it here at Drupal.org.

I don't think its that bad because you will find the download link right here and there is no need to visit github for downloading the newest version.

The only thing that won't work is a message in drupals module update status.

Greetings - Andreas

*deleted*

setting auto login & logout not working?

@vectoroc

ow soryy I missed this

7 .Edit the "page.tpl.php" file of your current theme. edit the tag and add the facebook xmlns for rendering XFBML.

	  example : <html xmlns="http://www.w3.org/1999/xhtml" xmlns:fb="http://www.facebook.com/2008/fbml">.

This is insane !
This version is so much better then the last beta !
I had to go with gigya and back to fbconnect just to accidentally find out about this version.

I don't think its that bad because you will find the download link right here and there is no need to visit github for downloading the newest version.

The only thing that won't work is a message in drupals module update status.

This is not true. people are not looking for modules on github. they are looking for them on drupal.org/project/modules and on drupalmodules.com, they will probably never find it elsewhere unless it is at least mentioned on the project page.
god only knows what would happen if we had to go through all the issues lists to find the best versions of every module.

vectoroc, thank you very much for your hard work ! I hope it will be an official release soon.

Vectoroc, could you apply to be a temporary maintainer like Gregarios suggested in comment #31? Then you could release the next beta and then stop being maintainer if you wish......

Hi to all,

the new version at github is now with lots of changes by vectoroc - and some of mine.. The new facebook api methods as described in #617778: Facebook depricates template bundles and their APIs... are not fully implemented - by facebook, so at the moment there is no way to post pictures or actionlinks to another facebook wall. facebook also moved the final depricate state to "early 2010".

In detail the changes are:

• themeable user picture if you use the facebook user picture
• allow/disallow the use of facebook user picture
• new api-methods for wall-postings (translateable)
• set your prefered language for facebook at the admin to get translated facebook prompts
• facebook connect button is now customizable with own text
• removed or rearranged some items in admin interface

If anything is wrong or missing just post it here.

regards - andreas

subscribing

Great patch/release vectoroc.

i agree #31. temp maintainer is better than none. Release in D.O have the cons that release got noticed by update_status.module.

anyone contacting this module's maintainer?

Hi Vectoroc, I could not log in to my drupal site using the facebook account. The popup window is coming and when i provide my facebook account details it is redirecting to my drupal site which is not logged in still. But when I open facebook it will be in logged in status. I have applied the patches you have provided and did a couple of re installation but nothing helped... pls advice

Thanks for the module..

+1 subscribing

I have an issue with your last patch, avatar not works. Users when register a new account with facebook, then no imaage avatar is updated.... with original release that functionality works... why?

I was using this version as in resolved the ssl problem on secure pages but I installed the secure pages prevent hijack module and it seems to have stopped working even after uninstalling secure pages prevent hijack module. Any suggestion on why this happening?