Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#15 Screenshot from 2023-01-21 13-30-39.png24.03 KBkevinquillen
#2 fakeobjects.1.x-dev.rector.patch481 bytesproject update bot

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new fakeobjects.1.x-dev.rector.patch481 bytes

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #127

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.9
  2. palantirnet/drupal-rector: 0.12.0
adrianm6254’s picture

adrianm6254 commented
Issue summary: View changes

This module is currently a requirement of drupal/pagebreak.

The status of that module is that their issue https://www.drupal.org/project/pagebreak/issues/3288949 is set to Closed (won't fix) by the maintainer.

Will have to wait for a patch to make that module Drupal 10 ready before moving forward.

adrianm6254’s picture

adrianm6254 commented
Issue tags: +Drupal 10 compatibility Drupal 10 porting day
kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Issue tags: -Drupal 10 compatibility Drupal 10 porting day +Drupal 10 porting day

@Adrianm6254 Thanks for participating in porting day! I'm fixing tags :)

project update bot’s picture

project update bot commented
Issue summary: View changes
kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Issue summary: View changes
Issue tags: +Needs manual testing

Regarding #3, the pagebreak module has a stable Drupal 10 release.

This module needs functional testing on Drupal 10. Adding general instructions:

https://www.drupal.org/community-initiatives/contribution-events-initiat...

mmjvb’s picture

mmjvb commented

This module being a requirement for other modules is irrelevant for refactoring deprecated code (this issue).

Normally, it is the other way around. Those modules having a requirement on this one could be postponed on this module D10 compatibility. It doesn't make sense to wait for the other modules.

As there is no refactoring done, suggest to commit apart from removing support for earlier D8 versions.

Again, testing on D10, tests D10, not this module. Suggest to wait for RC or Stable of D10. No need for testing functionality for D10 compatibility!

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Even though this module may not be needed for ckeditor5 there are some who won't be able to jump to ckeditor5 just yet but should still be able to upgrade to D10. So hopefully can get a release soon.

rajab natshah’s picture

rajab natshah
he/him
commented
Priority: Normal » Major
rajab natshah’s picture

rajab natshah
he/him
commented
Related issues: +#3277445: Support Drupal 10 and update all use of deprecation in the CKEditor Anchor Link module

Needed for the Anchor Link 8.x-2.x branch
#3277445: Support Drupal 10 and update all use of deprecation in the CKEditor Anchor Link module

Hoping for basic commit and a release to speed testing.

At this time hoping to have
Works with Drupal: ^8 || ^9 || ^10
and
Works with CKEditor: 4

loopy1492’s picture

loopy1492 commented

Applied the patch to v1.1.0 of fakeobjects which was a requirement for drupal/anchor_link dev-2.x.

This is a Drupal 9.5.1 site with CKEditor 4.10.0. ckeditor/fakeobjects is pinned to 4.14.0 on this site for some reason.

Upgrade Status module reports happiness.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

This is blocking D10 upgrades. Could someone perhaps contact the maintainers?

kevinquillen’s picture

kevinquillen commented

Does this also require the contributed CKEditor 4 module before flagging for Drupal 10? "drupal:ckeditor" is listed in the dependencies.

kevinquillen’s picture

kevinquillen commented
StatusFileSize
new Screenshot from 2023-01-21 13-30-39.png24.03 KB

I have made an update to the dev branch of this module and added some notes in the README. Does someone want to try that out and we can create a new release after verification?

kevinquillen’s picture

kevinquillen commented

  • kevinquillen committed 4c7a4c23 on 8.x-1.x 
    Issue #3287457 by Project Update Bot, Adrianm6254, Rajab Natshah,...
rajab natshah’s picture

rajab natshah
he/him
commented

Thanks, Kevin for sparing time to commit and maintain the module.

Had a Real physical testing round for CKEditor Anchor Link with CKEditor FakeObjects

Using the following bash commands
Real physical testing round for CKEditor Anchor Link with CKEditor FakeObjects.zip
from https://www.drupal.org/project/anchor_link/issues/3277445#comment-14885026

For

  • CKEditor Anchor Link 8.x-2.x branch with Drupal ~9.0 + CKEditor FakeObjects 8.x-1.x branch
  • CKEditor Anchor Link 8.x-2.x branch with Drupal ~10.0 + CKEditor FakeObjects 8.x-1.x branch

Hoping for a soft release ( pre-release ), which would help speeding up updating to Drupal 10 + CKEditor 4.

Then the work for the CKEditor 5 could start

After having look at what the Drupal Core CKEditor team are working on with other CKEditor 5 plugins
CKEditor BiDi Buttons the 4.0.x branch:
#3312442: [PP-1] Make ready for CKEditor 5
Linkit the 6.0.x branch:
#3232190: CKEditor 5 readiness

Learned a lot from that. About what CKEditor plugin module maintainers could do.

smustgrave’s picture

smustgrave commented

@Rajab Natshah the ckeditor bidi took a lot of trial and error so let me know if you have any questions.

rajab natshah’s picture

rajab natshah
he/him
commented
Priority: Major » Critical

Stephen, I do appreciate putting big time on that.
It would be good if you do publish a blog or a Drupal documentation article page about that. or a video.
For sure that will help many developers. Let all follow the best practice.
I was about to go into a wrong direction, But after looking at your code, the direction was changed to follow your practice.
---
On another subject, changing the priority to critical
After the full round for a real physical testing round for CKEditor FakeObjects 1.x-dev with Drupal 9 and Drupal 10, using the same base code.
Hoping for a soft tag release ( pre-release ), to speed up testing using the module with CKEditor 4 in Drupal 10 sites.

Thanks Kevin for sparing time to maintain this module.

kevinquillen’s picture

kevinquillen commented
Status: Reviewed & tested by the community » Fixed

Seeing as how nothing changes other than adding a D10 flag, I released it as 1.2.

smustgrave’s picture

smustgrave commented

Wooo! Thanks @kevinquillen!

Hopefully fakeobjects won't be needed for iframes and anchor links in ckeditor5 but that's been such a change who knows but least for us this gets us one step closer to D10.

rajab natshah’s picture

rajab natshah
he/him
commented

WOW
Thank you Kevin!!

Had a 2nd real physical testing round for CKEditor FakeObjects 8.x-1.2 in both Drupal 9 and Drupal 10.

✅ Released anchor_link-2.6.0

More post release testing for sure.
Starting the CKEditor 5 party.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.